[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: Refactor oa object to better manage resources

Patchwork patchwork at emeril.freedesktop.org
Wed May 1 17:15:05 UTC 2019


== Series Details ==

Series: drm/i915/perf: Refactor oa object to better manage resources
URL   : https://patchwork.freedesktop.org/series/60176/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
aec4c50375a0 drm/i915/perf: Refactor oa object to better manage resources
-:1161: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'stream->oa_buffer.last_ctx_id ==
 		     stream->specific_ctx_id'
#1161: FILE: drivers/gpu/drm/i915/i915_perf.c:791:
+		if (!dev_priv->perf.exclusive_stream->ctx ||
+		    stream->specific_ctx_id == ctx_id ||
+		    (stream->oa_buffer.last_ctx_id ==
+		     stream->specific_ctx_id) ||
 		    reason & OAREPORT_REASON_CTX_SWITCH) {

-:1520: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#1520: FILE: drivers/gpu/drm/i915/i915_perf.c:1367:
+	BUG_ON(stream != dev_priv->perf.exclusive_stream);

-:1792: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#1792: FILE: drivers/gpu/drm/i915/i915_perf.c:1838:
+			   _MASKED_BIT_ENABLE(

-:2271: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2271: FILE: drivers/gpu/drm/i915/i915_perf.c:3479:
+				dev_priv->perf.gen8_valid_ctx_bit = (1<<25);
 				                                      ^

-:2279: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2279: FILE: drivers/gpu/drm/i915/i915_perf.c:3484:
+				dev_priv->perf.gen8_valid_ctx_bit = (1<<16);
 				                                      ^

-:2305: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#2305: FILE: drivers/gpu/drm/i915/i915_perf.c:3502:
+			dev_priv->perf.gen8_valid_ctx_bit = (1<<16);
 			                                      ^

total: 0 errors, 1 warnings, 5 checks, 2163 lines checked



More information about the Intel-gfx mailing list