[Intel-gfx] [PATCH 29/40] drm/i915: Move GEM object waiting to its own file

Chris Wilson chris at chris-wilson.co.uk
Fri May 10 14:33:49 UTC 2019


Quoting Mika Kuoppala (2019-05-10 15:17:12)
> > diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
> > index edfc69acdaac..9911f53382a5 100644
> > --- a/drivers/gpu/drm/i915/i915_utils.h
> > +++ b/drivers/gpu/drm/i915/i915_utils.h
> > @@ -218,16 +218,6 @@ static inline unsigned long msecs_to_jiffies_timeout(const unsigned int m)
> >       return min_t(unsigned long, MAX_JIFFY_OFFSET, j + 1);
> >  }
> >  
> > -static inline unsigned long nsecs_to_jiffies_timeout(const u64 n)
> > -{
> > -     /* nsecs_to_jiffies64() does not guard against overflow */
> > -     if (NSEC_PER_SEC % HZ &&
> > -         div_u64(n, NSEC_PER_SEC) >= MAX_JIFFY_OFFSET / HZ)
> > -             return MAX_JIFFY_OFFSET;
> > -
> > -        return min_t(u64, MAX_JIFFY_OFFSET, nsecs_to_jiffies64(n) + 1);
> > -}
> 
> Seems that the wait stuff was only user so jiffiying the timeout. Just looks
> generic for other usage too.

But not generic enough to be in jiffies.h :)

I didn't want to clutter a common header with a one-off. But it can be
moved around on a whim, so not too concerned if this is not its final
resting place.
-Chris


More information about the Intel-gfx mailing list