[Intel-gfx] [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

[Summers, Stuart]

On Tue, 2019-05-14 at 17:53 +0100, Chris Wilson wrote:
> Quoting Stuart Summers (2019-05-14 17:46:52)
> > To allow easier debug of platforms which do not fully support
> > power-saving render C-state 6, add back the module parameter
> > to allow RC6 flows to be disabled. Instead of directly affecting
> > the RC6 states via a bitmask as done previously, use this module
> > parameter to clear the has_rc6 field for these platforms.
> 
> If you know which platforms don't support rc6, don't enable rc6.

I'd really prefer to have this parameter in place for debug purposes.
It seems more useful to allow quick testing by reloading i915 than by
requiring a rebuild.

Of course, once debug is complete and the platform is known to either
not support the feature or has some cripling bug around this, I agree,
rc6 shouldn't be enabled on that platform and i915 should be updated.

Thanks,
Stuart

> -Chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3270 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20190514/bf9cb189/attachment.bin>