[Intel-gfx] [PATCH v5 08/11] drm/fb-helper: Remove drm_fb_helper_connector

Sam Ravnborg sam at ravnborg.org
Thu May 16 15:36:00 UTC 2019


Hi Noralf.

On Thu, May 16, 2019 at 03:53:07PM +0200, Noralf Trønnes wrote:
> 
> 
> Den 16.05.2019 15.07, skrev Sam Ravnborg:
> > Hi Noralf.
> > 
> > See few comments in the following.
> > 
> > 	Sam
> > 
> > On Mon, May 06, 2019 at 08:01:36PM +0200, Noralf Trønnes wrote:
> >> All drivers add all their connectors so there's no need to keep around an
> >> array of available connectors.
> 
> I could expand on this text a little:
> 
> All drivers add all their connectors so there's no need to keep around an
> array of available connectors. Instead we just put the useable (not
> writeback) connectors in a temporary array using
> drm_client_for_each_connector_iter() everytime we probe the outputs.
> Other places where it's necessary to look at the connectors, we just
> iterate over them using the same iterator function.
Better, thanks.
After you clarified things looks good to me and you can add my:
Reviewed-by: Sam Ravnborg <sam at ravnborg.org>


More information about the Intel-gfx mailing list