[Intel-gfx] [PATCH] C: Revert "net/sch_generic: Shut up noise"

Daniel Vetter daniel.vetter at ffwll.ch
Fri May 17 06:48:13 UTC 2019


This reverts commit a9f840bdd2fd4cb07a669f1c3112b804218b4aba.

A quick test patch didn't seem to have hit this, so let's try what
happens when we reinstate the full WARNING again.

Cc: Martin Peres <martin.peres at free.fr>
---
 net/sched/sch_generic.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index cf96149d7b5e..a117d9260558 100644
--- a/net/sched/sch_generic.c
+++ b/net/sched/sch_generic.c
@@ -456,12 +456,7 @@ static void dev_watchdog(struct timer_list *t)
 				}
 			}
 
-			/* The noise is pissing off our CI and upstream doesn't
-			 * move on the bug report:
-			 *
-			 * https://bugzilla.kernel.org/show_bug.cgi?id=196399
-			 */
-			if (some_queue_timedout && 0) {
+			if (some_queue_timedout) {
 				WARN_ONCE(1, KERN_INFO "NETDEV WATCHDOG: %s (%s): transmit queue %u timed out\n",
 				       dev->name, netdev_drivername(dev), i);
 				dev->netdev_ops->ndo_tx_timeout(dev);
-- 
2.20.1



More information about the Intel-gfx mailing list