[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for fbcon notifier begone! (rev2)
Patchwork
patchwork at emeril.freedesktop.org
Tue May 21 17:08:19 UTC 2019
== Series Details ==
Series: fbcon notifier begone! (rev2)
URL : https://patchwork.freedesktop.org/series/60843/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
6712c9a81334 dummycon: Sprinkle locking checks
-:45: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 23 lines checked
a807564c5c46 fbdev: locking check for fb_set_suspend
-:34: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
2b0293d8a972 vt: might_sleep() annotation for do_blank_screen
-:32: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
1107db55b24f vt: More locking checks
-:70: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 38 lines checked
6b47d5be10cd fbdev/sa1100fb: Remove dead code
-:52: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 35 lines checked
ce4d9b2fd11a fbdev/cyber2000: Remove struct display
-:23: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 7 lines checked
79e09a42593a fbdev/aty128fb: Remove dead code
-:88: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 70 lines checked
c480f8ae010f fbcon: s/struct display/struct fbcon_display/
-:270: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#270: FILE: drivers/video/fbdev/core/fbcon.c:2117:
+static void updatescrollmode(struct fbcon_display *p,
struct fb_info *info,
-:384: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 1 checks, 317 lines checked
b1c755e3bb8f fbcon: Remove fbcon_has_exited
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev")'
#11:
commit 6104c37094e729f3d4ce65797002112735d49cd1
-:83: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#83: FILE: drivers/video/fbdev/core/fbcon.c:1065:
+ if (WARN_ON(info_idx == -1))
return;
-:193: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 1 errors, 2 warnings, 0 checks, 119 lines checked
80033c659633 fbcon: call fbcon_fb_(un)registered directly
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev")'
#11:
commit 6104c37094e729f3d4ce65797002112735d49cd1
-:168: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 1 errors, 1 warnings, 0 checks, 108 lines checked
684dfc3fee3d fbdev/sh_mobile: remove sh_mobile_lcdc_display_notify
b52f0088fedd fbdev/omap: sysfs files can't disappear before the device is gone
b65ada7e2f30 fbdev: sysfs files can't disappear before the device is gone
00c9c79479b0 staging/olpc: lock_fb_info can't fail
b5cd1d8e1556 fbdev/atyfb: lock_fb_info can't fail
3b25c5813357 fbdev: lock_fb_info cannot fail
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit c47747fde931 ("fbmem: make read/write/ioctl use the frame buffer at open time")'
#11:
commit c47747fde931c02455683bd00ea43eaa62f35b0e
-:307: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 1 errors, 1 warnings, 0 checks, 212 lines checked
c18a204aafc8 fbcon: call fbcon_fb_bind directly
-:160: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 107 lines checked
8fac90eead5b fbdev: make unregister/unlink functions not fail
-:209: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#209: FILE: include/linux/fb.h:630:
+extern void unregister_framebuffer(struct fb_info *fb_info);
-:210: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#210: FILE: include/linux/fb.h:631:
+extern void unlink_framebuffer(struct fb_info *fb_info);
-:213: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 2 checks, 174 lines checked
0a4973898b2e fbdev: unify unlink_framebufer paths
-:92: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 63 lines checked
a391d13a2e4c fbdev/sh_mob: Remove fb notifier callback
-:21: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6011bdeaa608 ("fbdev: sh-mobile: HDMI support for SH-Mobile SoCs")'
#21:
commit 6011bdeaa6089d49c02de69f05980da7bad314ab
-:107: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 1 errors, 1 warnings, 0 checks, 62 lines checked
d2190c7ac272 fbdev: directly call fbcon_suspended/resumed
-:126: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 77 lines checked
cdd591ad9935 fbcon: Call fbcon_mode_deleted/new_modelist directly
-:175: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#175: FILE: include/linux/fbcon.h:23:
+int fbcon_mode_deleted(struct fb_info *info,
+ struct fb_videomode *mode) { return 0; }
-:180: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 1 errors, 1 warnings, 0 checks, 123 lines checked
16a60c108b07 fbdev: Call fbcon_get_requirement directly
-:112: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#112: FILE: include/linux/fbcon.h:28:
+void fbcon_get_requirement(struct fb_info *info,
+ struct fb_blit_caps *caps) {}
-:116: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 1 errors, 1 warnings, 0 checks, 68 lines checked
e4067cf40df6 Revert "backlight/fbcon: Add FB_EVENT_CONBLANK"
-:83: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 42 lines checked
b7dc5daa5c88 fbcon: directly call fbcon_fb_blanked
-:76: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 38 lines checked
bbbe080b70df fbmem: pull fbcon_fb_blanked out of fb_blank
-:84: WARNING:CONSIDER_KSTRTO: simple_strtoul is obsolete, use kstrtoul instead
#84: FILE: drivers/video/fbdev/core/fbsysfs.c:311:
+ arg = simple_strtoul(buf, &last, 0);
-:94: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 40 lines checked
efc27439fc17 fbdev: remove FBINFO_MISC_USEREVENT around fb_blank
-:67: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 30 lines checked
4d7bf4833e17 fb: Flatten control flow in fb_set_var
-:141: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
#141: FILE: drivers/video/fbdev/core/fbmem.c:1027:
+ printk(KERN_WARNING "detected "
-:188: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 156 lines checked
a8e1ee647c16 fbcon: replace FB_EVENT_MODE_CHANGE/_ALL with direct calls
-:46: CHECK:LINE_SPACING: Please don't use multiple blank lines
#46: FILE: drivers/video/fbdev/core/fbcon.c:3012:
+
-:164: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 1 checks, 107 lines checked
a6b267d69013 vgaswitcheroo: call fbcon_remap_all directly
-:127: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 82 lines checked
20c0d8a6a167 fbcon: Call con2fb_map functions directly
-:73: WARNING:BRACES: braces {} are not necessary for single statement blocks
#73: FILE: drivers/video/fbdev/core/fbcon.c:3335:
+ if (!registered_fb[con2fb.framebuffer]) {
+ return -EINVAL;
}
-:208: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 156 lines checked
99cd5e3bdf8f fbcon: Document what I learned about fbcon locking
-:44: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 25 lines checked
f3dfc3547c56 staging/olpc_dcon: Add drm conversion to TODO
-:38: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 11 lines checked
More information about the Intel-gfx
mailing list