[Intel-gfx] [PATCH 2/3] drm/i915/huc: Check HuC firmware status only once

Chris Wilson chris at chris-wilson.co.uk
Wed May 22 20:13:43 UTC 2019


Quoting Michal Wajdeczko (2019-05-22 20:00:56)
> During driver load we checked that HuC firmware was verified, and once
> verified it stays verified, so there is no need to check that again.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tony Ye <tony.ye at intel.com>

Makes sense to me as purely a code monkey.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

I would like a second opinion from someone who knows the innards of the
HuC to confirm that indeed once verified, it remains verified. And if it
can change, we need to report the change in status to userspace (or they
just hang and the gpu + huc gets reset).
-Chris


More information about the Intel-gfx mailing list