[Intel-gfx] [PATCH v2 8/9] drm/i915/uc: Stop talking with GuC when resetting

Chris Wilson chris at chris-wilson.co.uk
Thu May 23 16:08:53 UTC 2019


Quoting Michal Wajdeczko (2019-05-23 16:53:27)
> On Wed, 22 May 2019 22:06:53 +0200, Chris Wilson  
> <chris at chris-wilson.co.uk> wrote:
> 
> > Quoting Michal Wajdeczko (2019-05-22 20:32:02)
> >> Knowing that GuC will be reset soon, we may stop all communication
> >> immediately without doing graceful cleanup as it is not needed.
> >
> > The difference between stop and disable is that it avoids the
> > serialisation, right? Is this patch still required -- do we still
> > need the complication in two similar but subtly different paths?
> 
> This patch helps us capture any unwanted/unexpected attempts to talk
> with GuC after we decided to reset it. We need 'disable' part as current
> and upcoming firmware still expects us to do graceful cleanup. This may
> be changed in the future releases. And we can use 'disable' as this will
> break atomic_reset tests.

Please promote that to the commitmsg :)
-Chris


More information about the Intel-gfx mailing list