[Intel-gfx] [PATCH 03/10] drm/i915/dmc: add support for package_header with version 2

[Lucas De Marchi]

On Thu, May 23, 2019 at 10:43:39AM -0700, Rodrigo Vivi wrote:
>On Thu, May 23, 2019 at 01:24:13AM -0700, Lucas De Marchi wrote:
>> The only meaninful change is that it supports up to 32 fw_info entries
>> rather than the previous max=20.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
>> ---
>>  drivers/gpu/drm/i915/intel_csr.c | 35 ++++++++++++++++++++++----------
>>  1 file changed, 24 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
>> index 01ae356e69cc..b9651fbe4c25 100644
>> --- a/drivers/gpu/drm/i915/intel_csr.c
>> +++ b/drivers/gpu/drm/i915/intel_csr.c
>> @@ -71,6 +71,7 @@ MODULE_FIRMWARE(BXT_CSR_PATH);
>>
>>  #define CSR_DEFAULT_FW_OFFSET		0xFFFFFFFF
>>  #define PACKAGE_MAX_FW_INFO_ENTRIES	20
>> +#define PACKAGE_V2_MAX_FW_INFO_ENTRIES	32
>
>Looking to spec I could only find
>"} FWInfo[20];"
>
>Where did you get the 32?

you are looking to the struct for header_ver == 1. Look to the one with
header_ver == 2.

Lucas De Marchi