[Intel-gfx] [PATCH v6 0/8] drm/fb-helper: Move modesetting code to drm_client

Gerd Hoffmann kraxel at redhat.com
Fri May 24 12:10:28 UTC 2019


On Thu, May 23, 2019 at 06:53:20PM +0200, Sam Ravnborg wrote:
> Hi Linus, Gerd.
> 
> > This moves the modesetting code from drm_fb_helper to drm_client so it
> > can be shared by all internal clients.
> 
> Could one of you take a look at this series.
> Daniel already ack'ed the series on irc, but an extra pair of eyes
> is never bad.
> 
> For my part I have been through them all, but I still do not have
> the full picture of the DRM subsystem so my review may not
> suffice.

Looks sane to me overall.  Tried to give the series a spin in qemu, but:

ERROR: "drm_client_panel_rotation" [drivers/gpu/drm/drm_kms_helper.ko]
undefined!

EXPORT_SYMBOL() missing?

cheers,
  Gerd



More information about the Intel-gfx mailing list