[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for fbcon notifier begone! (rev4)
Patchwork
patchwork at emeril.freedesktop.org
Sun May 26 15:34:47 UTC 2019
== Series Details ==
Series: fbcon notifier begone! (rev4)
URL : https://patchwork.freedesktop.org/series/60843/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
01d758cc0fca dummycon: Sprinkle locking checks
-:45: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 23 lines checked
36de54ed5cd0 fbdev: locking check for fb_set_suspend
-:34: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
239b82cd1fb5 vt: might_sleep() annotation for do_blank_screen
-:32: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
cba9ec8bf81b vt: More locking checks
-:70: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 38 lines checked
8cb463006c51 fbdev/sa1100fb: Remove dead code
-:52: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 35 lines checked
177f19856b50 fbdev/cyber2000: Remove struct display
-:23: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 7 lines checked
17e17e70e8d4 fbdev/aty128fb: Remove dead code
-:88: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 70 lines checked
6fadcddd56c7 fbcon: s/struct display/struct fbcon_display/
-:270: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#270: FILE: drivers/video/fbdev/core/fbcon.c:2117:
+static void updatescrollmode(struct fbcon_display *p,
struct fb_info *info,
-:384: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 1 checks, 317 lines checked
f6fe0650a44a fbcon: Remove fbcon_has_exited
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev")'
#11:
commit 6104c37094e729f3d4ce65797002112735d49cd1
-:83: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#83: FILE: drivers/video/fbdev/core/fbcon.c:1065:
+ if (WARN_ON(info_idx == -1))
return;
-:193: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 1 errors, 2 warnings, 0 checks, 119 lines checked
de0f6c214a7a fbcon: call fbcon_fb_(un)registered directly
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6104c37094e7 ("fbcon: Make fbcon a built-time depency for fbdev")'
#11:
commit 6104c37094e729f3d4ce65797002112735d49cd1
-:155: WARNING:LINE_SPACING: Missing a blank line after declarations
#155: FILE: drivers/video/fbdev/core/fbmem.c:1728:
+ struct fb_event event;
+ event.info = fb_info;
-:190: WARNING:LINE_SPACING: Missing a blank line after declarations
#190: FILE: drivers/video/fbdev/core/fbmem.c:1799:
+ struct fb_event event;
+ event.info = fb_info;
-:237: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 1 errors, 3 warnings, 0 checks, 147 lines checked
84d9a7867bed fbdev/sh_mobile: remove sh_mobile_lcdc_display_notify
-:46: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#46:
> diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c
-:188: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 1 warnings, 0 checks, 32 lines checked
7bfec3f9ea6f fbdev/omap: sysfs files can't disappear before the device is gone
cbbee3bc9cb4 fbdev: sysfs files can't disappear before the device is gone
120561b65ee3 staging/olpc: lock_fb_info can't fail
22d4bb5cf961 fbdev/atyfb: lock_fb_info can't fail
b572fa6f6893 fbdev: lock_fb_info cannot fail
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit c47747fde931 ("fbmem: make read/write/ioctl use the frame buffer at open time")'
#11:
commit c47747fde931c02455683bd00ea43eaa62f35b0e
-:307: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 1 errors, 1 warnings, 0 checks, 212 lines checked
0055f13058c0 fbcon: call fbcon_fb_bind directly
-:160: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 107 lines checked
3496c377254c fbdev: make unregister/unlink functions not fail
-:284: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#284: FILE: include/linux/fb.h:637:
+extern void unregister_framebuffer(struct fb_info *fb_info);
-:285: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#285: FILE: include/linux/fb.h:638:
+extern void unlink_framebuffer(struct fb_info *fb_info);
-:288: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 2 checks, 226 lines checked
210468c2a0aa fbdev: unify unlink_framebuffer paths
-:95: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 63 lines checked
dd3283bf31ae fbdev/sh_mob: Remove fb notifier callback
-:21: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6011bdeaa608 ("fbdev: sh-mobile: HDMI support for SH-Mobile SoCs")'
#21:
commit 6011bdeaa6089d49c02de69f05980da7bad314ab
-:107: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 1 errors, 1 warnings, 0 checks, 62 lines checked
59d7c6bdb0e6 fbdev: directly call fbcon_suspended/resumed
-:128: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 77 lines checked
f761b599f9ca fbcon: Call fbcon_mode_deleted/new_modelist directly
-:182: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 123 lines checked
b1f179047c20 fbdev: Call fbcon_get_requirement directly
-:118: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 68 lines checked
2c0d7d40ee5b Revert "backlight/fbcon: Add FB_EVENT_CONBLANK"
-:136: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 80 lines checked
b986ec15066a fbmem: pull fbcon_fb_blanked out of fb_blank
-:84: WARNING:CONSIDER_KSTRTO: simple_strtoul is obsolete, use kstrtoul instead
#84: FILE: drivers/video/fbdev/core/fbsysfs.c:311:
+ arg = simple_strtoul(buf, &last, 0);
-:94: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 40 lines checked
6f15cce10e68 fbdev: remove FBINFO_MISC_USEREVENT around fb_blank
-:67: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 30 lines checked
645b868c2124 fb: Flatten control flow in fb_set_var
-:141: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ...
#141: FILE: drivers/video/fbdev/core/fbmem.c:1027:
+ printk(KERN_WARNING "detected "
-:188: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 156 lines checked
29f65aba43d2 fbcon: replace FB_EVENT_MODE_CHANGE/_ALL with direct calls
-:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14:
to Maarten for spotting this. So we keep that. We can ditch the differentiation
-:57: CHECK:LINE_SPACING: Please don't use multiple blank lines
#57: FILE: drivers/video/fbdev/core/fbcon.c:3012:
+
-:184: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 2 warnings, 1 checks, 114 lines checked
0cec55b0634a vgaswitcheroo: call fbcon_remap_all directly
-:132: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 83 lines checked
27ab47ced5bc fbcon: Call con2fb_map functions directly
-:87: WARNING:BRACES: braces {} are not necessary for single statement blocks
#87: FILE: drivers/video/fbdev/core/fbcon.c:3335:
+ if (!registered_fb[con2fb.framebuffer]) {
+ return -EINVAL;
}
-:237: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 2 warnings, 0 checks, 171 lines checked
6ea0568e1a4d fbcon: Document what I learned about fbcon locking
-:43: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 25 lines checked
bf038eb142c1 staging/olpc_dcon: Add drm conversion to TODO
-:38: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 11 lines checked
7e06cf82ba5a backlight: simplify lcd notifier
-:38: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter at ffwll.ch>'
total: 0 errors, 1 warnings, 0 checks, 17 lines checked
More information about the Intel-gfx
mailing list