[Intel-gfx] [PATCH v2 0/7] drm: make headers self-contained and drop drmP.h

[Sam Ravnborg]

Hi Daniel.
On Mon, May 27, 2019 at 08:18:35AM +0200, Daniel Vetter wrote:
> On Sun, May 26, 2019 at 07:35:28PM +0200, Sam Ravnborg wrote:
> > While removing use of drmP.h from files in drm/* I
> > noticed that I had to add the same include files due to
> > dependencies in the header files.
> > 
> > It is better to let the header files be self-contained and
> > let the users pull in only the additional headers files required.
> > So I went ahead and made the relevant header files self-contained.
> > (I did not check if this made any includes redundant in some files,
> > I do not have tooling in place to do so).
> > 
> > Daniel suggested to add support for testing that they stay
> > self contained.
> > Jani Nikula has sent a patch to kbuild to make this part of the
> > kbuild machinery. I have used it locally and as soon as it
> > lands in kbuild I will start using it for drm.
> > We could have duplicated the infrastructure now but that seemed
> > too much code chrunch.
> > 
> > This patchset include the actual removal of drmP.h as one big patch.
> > This is build tested on alpha (always interesting), arm, arm64, x86 etc.
> > 
> > For all files touched the following was done:
> > - include files divided up in blocks in following order:
> >     	linux/*
> > 	video/*
> > 	drm/*
> > 	""
> > - within each block the include files are sorted alphabetically
> > 
> > v2:
> > - use same ordering af blocks
> > - move includes down below license text
> > - added patch with actual drmP.h removal
> > - reworded some subjects to make them more descriptive
> > - fixed a few spelling erros in changelogs (but a few may remain)
> > 
> >         Sam
> 
> On the series:
> 
> Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch>
Thanks

> 
> Did a bit of scrolling, looks all reasonable, but definitely didn't check
> things in-depth.
> 
> btw did you look at the i915 Makefile trickery to make sure headers stay
> self-contained?
Yup, this is what Jani works on getting upstreamed to be part of kbuild.
When it lands I will activate it for the drm headers (if not beaten by
someone else)
I used it locally to check everything was OK.

	Sam