[Intel-gfx] [PATCH 2/2] drm/i915: Add debugs for the C8 vs. legacy LUT case

Ville Syrjälä ville.syrjala at linux.intel.com
Tue May 28 17:49:25 UTC 2019


On Tue, May 28, 2019 at 12:51:04PM +0200, Maarten Lankhorst wrote:
> Op 13-05-2019 om 15:39 schreef Ville Syrjala:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> >
> > Leave a hint in dmesg when we reject a configuration attempting
> > to use C8 planes without the legacy LUT loaded.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_color.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c
> > index 962db1236970..45649904ba5c 100644
> > --- a/drivers/gpu/drm/i915/intel_color.c
> > +++ b/drivers/gpu/drm/i915/intel_color.c
> > @@ -959,8 +959,10 @@ static int check_luts(const struct intel_crtc_state *crtc_state)
> >  		return 0;
> >  
> >  	/* C8 relies on its palette being stored in the legacy LUT */
> > -	if (crtc_state->c8_planes)
> > +	if (crtc_state->c8_planes) {
> > +		DRM_DEBUG_KMS("C8 pixelformat requires the legacy LUT\n");
> >  		return -EINVAL;
> > +	}
> >  
> >  	degamma_length = INTEL_INFO(dev_priv)->color.degamma_lut_size;
> >  	gamma_length = INTEL_INFO(dev_priv)->color.gamma_lut_size;
> 
> For the series:
> 
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>

Thanks. Pushed.

-- 
Ville Syrjälä
Intel


More information about the Intel-gfx mailing list