[Intel-gfx] [igt-dev] [PATCH i-g-t] prime_vgem: Fix typo in checking for invalid engines

Petri Latvala petri.latvala at intel.com
Wed May 29 08:12:44 UTC 2019


On Mon, May 27, 2019 at 09:36:16AM +0100, Chris Wilson wrote:
> Move the stray ')' from
> 
> 	gem_can_store_dword(exec_id) | exec_flags
> 
> to
> 
> 	gem_can_store_dword(exec_id | exec_flags)
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110764
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Petri Latvala <petri.latvala at intel.com>

> ---
>  tests/prime_vgem.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/prime_vgem.c b/tests/prime_vgem.c
> index 09e3373be..69ae8c9b0 100644
> --- a/tests/prime_vgem.c
> +++ b/tests/prime_vgem.c
> @@ -845,7 +845,7 @@ igt_main
>  			      e->exec_id == 0 ? "basic-" : "",
>  			      e->name) {
>  			gem_require_ring(i915, e->exec_id | e->flags);
> -			igt_require(gem_can_store_dword(i915, e->exec_id) | e->flags);
> +			igt_require(gem_can_store_dword(i915, e->exec_id | e->flags));
>  
>  			gem_quiescent_gpu(i915);
>  			test_sync(i915, vgem, e->exec_id, e->flags);
> @@ -857,7 +857,7 @@ igt_main
>  			      e->exec_id == 0 ? "basic-" : "",
>  			      e->name) {
>  			gem_require_ring(i915, e->exec_id | e->flags);
> -			igt_require(gem_can_store_dword(i915, e->exec_id) | e->flags);
> +			igt_require(gem_can_store_dword(i915, e->exec_id | e->flags));
>  
>  			gem_quiescent_gpu(i915);
>  			test_busy(i915, vgem, e->exec_id, e->flags);
> @@ -869,7 +869,7 @@ igt_main
>  			      e->exec_id == 0 ? "basic-" : "",
>  			      e->name) {
>  			gem_require_ring(i915, e->exec_id | e->flags);
> -			igt_require(gem_can_store_dword(i915, e->exec_id) | e->flags);
> +			igt_require(gem_can_store_dword(i915, e->exec_id | e->flags));
>  
>  			gem_quiescent_gpu(i915);
>  			test_wait(i915, vgem, e->exec_id, e->flags);
> @@ -892,7 +892,7 @@ igt_main
>  					e->exec_id == 0 ? "basic-" : "",
>  					e->name) {
>  				gem_require_ring(i915, e->exec_id | e->flags);
> -				igt_require(gem_can_store_dword(i915, e->exec_id) | e->flags);
> +				igt_require(gem_can_store_dword(i915, e->exec_id | e->flags));
>  
>  				gem_quiescent_gpu(i915);
>  				test_fence_wait(i915, vgem, e->exec_id, e->flags);
> -- 
> 2.20.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev


More information about the Intel-gfx mailing list