[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] drm/i915: Add windowing for primary planes on gen2/3 and chv

Patchwork patchwork at emeril.freedesktop.org
Wed May 29 17:38:03 UTC 2019


== Series Details ==

Series: series starting with [01/10] drm/i915: Add windowing for primary planes on gen2/3 and chv
URL   : https://patchwork.freedesktop.org/series/61345/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
5682a7985cac drm/i915: Add windowing for primary planes on gen2/3 and chv
9be64e7c694a drm/i915: Disable sprite gamma on ivb-bdw
4dc524e6adde drm/i915: Program plane gamma ramps
-:39: WARNING:LONG_LINE_COMMENT: line over 100 characters
#39: FILE: drivers/gpu/drm/i915/i915_reg.h:6290:
+#define DSPGAMC(plane, i)	_MMIO(_PIPE2(plane, _DSPAGAMC) + (5 - (i)) * 4) /* plane C only, 6 x u0.8 */

-:77: WARNING:LONG_LINE_COMMENT: line over 100 characters
#77: FILE: drivers/gpu/drm/i915/i915_reg.h:6433:
+#define DVSGAMC_G4X(pipe, i) _MMIO(_PIPE(pipe, _DVSAGAMC_G4X, _DVSBGAMC_G4X) + (5 - (i)) * 4) /* 6 x u0.8 */

-:78: WARNING:LONG_LINE_COMMENT: line over 100 characters
#78: FILE: drivers/gpu/drm/i915/i915_reg.h:6434:
+#define DVSGAMC_ILK(pipe, i) _MMIO(_PIPE(pipe, _DVSAGAMC_ILK, _DVSBGAMC_ILK) + (i) * 4) /* 16 x u0.10 */

-:79: WARNING:LONG_LINE_COMMENT: line over 100 characters
#79: FILE: drivers/gpu/drm/i915/i915_reg.h:6435:
+#define DVSGAMCMAX_ILK(pipe, i) _MMIO(_PIPE(pipe, _DVSAGAMCMAX_ILK, _DVSBGAMCMAX_ILK) + (i) * 4) /* 3 x u1.10 */

-:141: WARNING:LONG_LINE: line over 100 characters
#141: FILE: drivers/gpu/drm/i915/i915_reg.h:6595:
+#define SPGAMC(pipe, plane_id, i)	_MMIO(_VLV_SPR((pipe), (plane_id), _SPAGAMC, _SPBGAMC) + (5 - (i)) * 4) /* 6 x u0.10 */

total: 0 errors, 5 warnings, 0 checks, 290 lines checked
59f4e356a17e drm/i915: Deal with cpp==8 for g4x watermarks
3a33204e1ac6 drm/i915: Cosmetic fix for skl+ plane switch statement
e759b5c52ae5 drm/i915: Clean up skl vs. icl plane formats
-:147: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#147: FILE: drivers/gpu/drm/i915/intel_sprite.c:2351:
+		return skl_planar_formats;
+	} else {

-:160: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#160: FILE: drivers/gpu/drm/i915/intel_sprite.c:2364:
+		return glk_planar_formats;
+	} else {

-:176: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#176: FILE: drivers/gpu/drm/i915/intel_sprite.c:2380:
+		return icl_sdr_y_plane_formats;
+	} else {

total: 0 errors, 3 warnings, 0 checks, 191 lines checked
d2d01e7713c7 drm/i915: Add support for half float framebuffers for skl+
f30f3f2742af drm/i915: Add support for half float framebuffers for gen4+ primary planes
37f3c4da7abc drm/i915: Add support for half float framebuffers for ivb+ sprites
29cb57ac5fd4 drm/i915: Add support for half float framebuffers on snb sprites



More information about the Intel-gfx mailing list