[Intel-gfx] [PATCH 2/2] drm/i915: Report all objects with allocated pages to the shrinker

Chris Wilson chris at chris-wilson.co.uk
Thu May 30 19:10:24 UTC 2019


Quoting Matthew Auld (2019-05-30 17:10:16)
> On Tue, 28 May 2019 at 20:50, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> > index fb2e89133e78..770c54b87de6 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -926,10 +926,9 @@ struct i915_gem_mm {
> >         /** Bit 6 swizzling required for Y tiling */
> >         u32 bit_6_swizzle_y;
> >
> > -       /* accounting, useful for userland debugging */
> > -       spinlock_t object_stat_lock;
> > -       u64 object_memory;
> > -       u32 object_count;
> > +       /* shrinker accounting, also useful for userland debugging */
> > +       u64 shrink_memory;
> > +       u32 shrink_count;
> 
> Colour me confused. I can't see where we set these? Or is my brain fried?

They used to be set on add/removing obj->mm.pages... That looks to have
vanished. I wonder if I have an older version to save me the hassle of
adding two functions :)
-Chris


More information about the Intel-gfx mailing list