[Intel-gfx] [PATCH] drm/i915: Always enable mmio debugging for CI

[Joonas Lahtinen]

Quoting Chris Wilson (2019-05-30 15:13:11)
> The default behaviour is to periodically check for a mmio access error,
> and once detected enable mmio access checking. However this is useless
> if the error only occurs once.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala at intel.com>

<SNIP>

> @@ -41,6 +42,17 @@ config DRM_I915_DEBUG
>  
>            If in doubt, say "N".
>  
> +config DRM_I915_DEBUG_MMIO
> +        bool "Always insert extra checks around mmio access"
> +        default n
> +        help
> +         Always enables the extra sanity checks (extra register reads)
> +         around every mmio (register) access that will slow the system down.

Indent off by one space. Maybe also worth mentioning that this can still be
disabled with .mmio_debug=0?

> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -33,6 +33,12 @@ struct drm_printer;
>  #define ENABLE_GUC_SUBMISSION          BIT(0)
>  #define ENABLE_GUC_LOAD_HUC            BIT(1)
>  
> +#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_MMIO)
> +#define MMIO_DEBUG_DFL -1
> +#else
> +#define MMIO_DEBUG_DFL 0
> +#endif

Just call it _DEFAULT for clarity.

With above fixed:

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas