[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/fb-helper: Move modesetting code to drm_client (rev8)

[Patchwork]

== Series Details ==

Series: drm/fb-helper: Move modesetting code to drm_client (rev8)
URL   : https://patchwork.freedesktop.org/series/58597/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
7f8f155f76d9 drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()
03e436436a8d drm/fb-helper: Remove drm_fb_helper_crtc
-:130: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#130: 
new file mode 100644

-:207: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#207: FILE: drivers/gpu/drm/drm_client_modeset.c:73:
+}
+/* TODO: Remove export when modeset code has been moved over */

-:237: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#237: FILE: drivers/gpu/drm/drm_client_modeset.c:103:
+}
+/* TODO: Remove export when modeset code has been moved over */

-:931: WARNING:LONG_LINE: line over 100 characters
#931: FILE: drivers/gpu/drm/drm_fb_helper.c:2771:
+			if (WARN_ON_ONCE(modeset->num_connectors == DRM_CLIENT_MAX_CLONED_CONNECTORS ||

-:932: WARNING:LONG_LINE: line over 100 characters
#932: FILE: drivers/gpu/drm/drm_fb_helper.c:2772:
+					 (dev->mode_config.num_crtc > 1 && modeset->num_connectors == 1)))

-:1066: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'modeset' - possible side-effects?
#1066: FILE: include/drm/drm_client.h:164:
+#define drm_client_for_each_modeset(modeset, client) \
+	for (({ lockdep_assert_held(&(client)->modeset_mutex); }), \
+	     modeset = (client)->modesets; modeset->crtc; modeset++)

-:1066: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'client' - possible side-effects?
#1066: FILE: include/drm/drm_client.h:164:
+#define drm_client_for_each_modeset(modeset, client) \
+	for (({ lockdep_assert_held(&(client)->modeset_mutex); }), \
+	     modeset = (client)->modesets; modeset->crtc; modeset++)

total: 0 errors, 3 warnings, 4 checks, 958 lines checked
5bd5173fe7fd drm/fb-helper: Prepare to move out commit code
fdb3c200a4fc drm/fb-helper: Move out commit code
-:155: WARNING:LONG_LINE: line over 100 characters
#155: FILE: drivers/gpu/drm/drm_client_modeset.c:224:
+			struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state, crtc);

-:288: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#288: FILE: drivers/gpu/drm/drm_client_modeset.c:357:
+			drm_object_property_set_value(&connector->base,
+				dev->mode_config.dpms_property, dpms_mode);

total: 0 errors, 1 warnings, 1 checks, 616 lines checked
b7f8314057cf drm/fb-helper: Remove drm_fb_helper_connector
-:596: WARNING:LONG_LINE: line over 100 characters
#596: FILE: drivers/gpu/drm/drm_fb_helper.c:1974:
+				      connector->base.id, connector->tile_group ? connector->tile_group->id : 0);

-:953: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#953: FILE: include/drm/drm_client.h:183:
+#define drm_client_for_each_connector_iter(connector, iter) \
+	drm_for_each_connector_iter(connector, iter) \
+		if (connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK)

-:953: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'connector' - possible side-effects?
#953: FILE: include/drm/drm_client.h:183:
+#define drm_client_for_each_connector_iter(connector, iter) \
+	drm_for_each_connector_iter(connector, iter) \
+		if (connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK)

total: 1 errors, 1 warnings, 1 checks, 1007 lines checked
e365bfaa0beb drm/fb-helper: Prepare to move out modeset config code
-:170: WARNING:LONG_LINE: line over 100 characters
#170: FILE: drivers/gpu/drm/drm_fb_helper.c:2367:
+					 (dev->mode_config.num_crtc > 1 && modeset->num_connectors == 1))) {

total: 0 errors, 1 warnings, 0 checks, 179 lines checked
0c65faf4aac7 drm/fb-helper: Move out modeset config code
-:100: CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#100: FILE: drivers/gpu/drm/drm_client_modeset.c:140:
+	if (cmdline_mode->specified == false)

-:171: WARNING:LONG_LINE: line over 100 characters
#171: FILE: drivers/gpu/drm/drm_client_modeset.c:211:
+			      connector->display_info.non_desktop ? "non desktop" : enabled[i] ? "yes" : "no");

-:315: CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#315: FILE: drivers/gpu/drm/drm_client_modeset.c:355:
+		if (enabled[i] == false) {

-:349: WARNING:LONG_LINE: line over 100 characters
#349: FILE: drivers/gpu/drm/drm_client_modeset.c:389:
+				      connector->base.id, connector->tile_group ? connector->tile_group->id : 0);

-:405: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!modes[n]"
#405: FILE: drivers/gpu/drm/drm_client_modeset.c:445:
+	if (modes[n] == NULL)

-:737: WARNING:LONG_LINE: line over 100 characters
#737: FILE: drivers/gpu/drm/drm_client_modeset.c:777:
+			if (WARN_ON_ONCE(modeset->num_connectors == DRM_CLIENT_MAX_CLONED_CONNECTORS ||

-:738: WARNING:LONG_LINE: line over 100 characters
#738: FILE: drivers/gpu/drm/drm_client_modeset.c:778:
+					 (dev->mode_config.num_crtc > 1 && modeset->num_connectors == 1))) {

-:1497: WARNING:LONG_LINE: line over 100 characters
#1497: FILE: include/drm/drm_client.h:155:
+int drm_client_modeset_probe(struct drm_client_dev *client, unsigned int width, unsigned int height);

total: 0 errors, 5 warnings, 3 checks, 1465 lines checked
34c5b096ab89 drm/client: Hack: Add bootsplash example
-:31: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully
#31: FILE: drivers/gpu/drm/Kconfig:69:
+config DRM_CLIENT_BOOTSPLASH

-:52: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

-:57: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#57: FILE: drivers/gpu/drm/drm_bootsplash.c:1:
+/* DRM internal client example */

-:83: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#83: FILE: drivers/gpu/drm/drm_bootsplash.c:27:
+	struct mutex lock;

-:121: WARNING:LONG_LINE: line over 100 characters
#121: FILE: drivers/gpu/drm/drm_bootsplash.c:65:
+		splash->buffers[i] = drm_client_framebuffer_create(&splash->client, width, height, DRM_FORMAT_XRGB8888);

-:269: WARNING:LONG_LINE: line over 100 characters
#269: FILE: drivers/gpu/drm/drm_bootsplash.c:213:
+static int drm_bootsplash_draw(struct drm_bootsplash *splash, unsigned int sequence, unsigned int buffer_num)

total: 0 errors, 5 warnings, 1 checks, 412 lines checked