[Intel-gfx] [PATCH] drm/i915/gtt: No need to zero the table for page dirs

[Chris Wilson]

Quoting Mika Kuoppala (2019-05-31 17:18:36)
> We set them to scratch right after allocation so prevent
> useless zeroing before.
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index ca8a69e8b098..f237ad310426 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -681,7 +681,7 @@ static struct i915_page_directory *alloc_pd(struct i915_address_space *vm)
>  {
>         struct i915_page_directory *pd;
>  
> -       pd = kzalloc(sizeof(*pd), I915_GFP_ALLOW_FAIL);
> +       pd = kmalloc(sizeof(*pd), I915_GFP_ALLOW_FAIL);
>         if (unlikely(!pd))
>                 return ERR_PTR(-ENOMEM);
>  
> @@ -738,7 +738,7 @@ alloc_pdp(struct i915_address_space *vm)
>  
>         GEM_BUG_ON(!i915_vm_is_4lvl(vm));
>  
> -       pdp = kzalloc(sizeof(*pdp), GFP_KERNEL);
> +       pdp = kmalloc(sizeof(*pdp), GFP_KERNEL);
>         if (!pdp)
>                 return ERR_PTR(-ENOMEM);
>  
> @@ -750,6 +750,7 @@ alloc_pdp(struct i915_address_space *vm)
>         if (ret)
>                 goto fail_page_m;
>  
> +       pdp->used_pdpes = 0;

-> __pdp_init.

That makes more sense when you see my patches ;)

With putting initialisation in __pdp_init
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris