[Intel-gfx] [PATCH 1/2] drm/i915/gt: Drop false assertion on user_forcewake

Mika Kuoppala mika.kuoppala at linux.intel.com
Mon Nov 4 09:38:33 UTC 2019


Chris Wilson <chris at chris-wilson.co.uk> writes:

> The counter is removed from the pm wakeref count, but it remains intact
> so that we can restore it upon resume. Ergo inside suspend, it may have
> a value.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

oh, user_forcewake needs a better name with a verb...

> ---
>  drivers/gpu/drm/i915/gt/intel_gt_pm.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> index 6374744bb65e..060a27d9af34 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> @@ -251,7 +251,6 @@ static void wait_for_suspend(struct intel_gt *gt)
>  		intel_gt_set_wedged(gt);
>  	}
>  
> -	GEM_BUG_ON(atomic_read(&gt->user_wakeref));
>  	intel_gt_pm_wait_for_idle(gt);
>  }
>  
> -- 
> 2.24.0.rc2


More information about the Intel-gfx mailing list