[Intel-gfx] [PATCH] drm/i915: Display WA2006604312 is needed from ICL onwards

Matt Roper matthew.d.roper at intel.com
Mon Nov 4 16:32:46 UTC 2019


On Mon, Nov 04, 2019 at 01:50:09PM +0200, Juha-Pekka Heikkila wrote:
> WA2006604312 is listed for devices from Icelake onward.

The "Project" column on bspec #33450 does list EHL, however I don't see
it actually listed on the dedicated EHL WA page (bspec #33451) or the
TGL WA page (bspec #52890).

I'm not sure which page we're supposed to trust for EHL (personally I'd
trust the EHL page more than the ICL page when it comes to EHL), but it
doesn't look like this should apply to TGL/gen12 as far as I can see?


Matt

> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index e29e80ae5698..71ac4fe5fb47 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -5981,7 +5981,7 @@ static bool needs_scalerclk_wa(struct drm_i915_private *dev_priv,
>  			       const struct intel_crtc_state *crtc_state)
>  {
>  	/* Wa_2006604312:icl */
> -	if (crtc_state->scaler_state.scaler_users > 0 && IS_ICELAKE(dev_priv))
> +	if (crtc_state->scaler_state.scaler_users > 0 && INTEL_GEN(dev_priv) >= 11)
>  		return true;
>  
>  	return false;
> -- 
> 2.17.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795


More information about the Intel-gfx mailing list