[Intel-gfx] [PATCH 15/16] drm/i915/gem: Distinguish each object type

Daniel Vetter daniel at ffwll.ch
Mon Nov 4 17:51:35 UTC 2019


On Tue, Oct 22, 2019 at 03:30:13PM +0100, Matthew Auld wrote:
> On Mon, 21 Oct 2019 at 09:03, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> >
> > Separate each object class into a separate lock type to avoid lockdep
> > cross-contamination between paths (i.e. userptr!).
> >
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Matthew Auld <matthew.auld at intel.com>
> 
> As per the explanation you gave on IRC, makes sense.
> Reviewed-by: Matthew Auld <matthew.auld at intel.com>

It would be really lovely if such explanations would make it from
ephemeral irc onto something more permanent like mailing lists, or even
better, commit messages :-)

So, why do we need this?

I'm wondering since aside from userptr we'll have to unify how locking for
bo works longer term (with all the dma_buf/ww_mutex stuff going on), not
make it more distinct.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the Intel-gfx mailing list