[Intel-gfx] [PATCH v2 1/4] drm/i915/dsc: make parameter arrays const

Manasi Navare manasi.d.navare at intel.com
Mon Nov 4 22:23:16 UTC 2019


On Mon, Nov 04, 2019 at 04:14:36PM +0200, Jani Nikula wrote:
> No need for them to be mutable.
> 
> Cc: Manasi Navare <manasi.d.navare at intel.com>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>

Agree that these params are constants

Reviewed-by: Manasi Navare <manasi.d.navare at intel.com>

Manasi

> ---
>  drivers/gpu/drm/i915/display/intel_vdsc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/drm/i915/display/intel_vdsc.c
> index 9cb36f855f07..763f1d7208e9 100644
> --- a/drivers/gpu/drm/i915/display/intel_vdsc.c
> +++ b/drivers/gpu/drm/i915/display/intel_vdsc.c
> @@ -33,7 +33,7 @@ enum COLUMN_INDEX_BPC {
>  #define DSC_SUPPORTED_VERSION_MIN		1
>  
>  /* From DSC_v1.11 spec, rc_parameter_Set syntax element typically constant */
> -static u16 rc_buf_thresh[] = {
> +static const u16 rc_buf_thresh[] = {
>  	896, 1792, 2688, 3584, 4480, 5376, 6272, 6720, 7168, 7616,
>  	7744, 7872, 8000, 8064
>  };
> @@ -53,7 +53,7 @@ struct rc_parameters {
>   * Selected Rate Control Related Parameter Recommended Values
>   * from DSC_v1.11 spec & C Model release: DSC_model_20161212
>   */
> -static struct rc_parameters rc_params[][MAX_COLUMN_INDEX] = {
> +static const struct rc_parameters rc_params[][MAX_COLUMN_INDEX] = {
>  {
>  	/* 6BPP/8BPC */
>  	{ 768, 15, 6144, 3, 13, 11, 11, {
> -- 
> 2.20.1
> 


More information about the Intel-gfx mailing list