[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/28] drm/i915: Leave the aliasing-ppgtt size alone

Patchwork patchwork at emeril.freedesktop.org
Thu Nov 7 11:18:04 UTC 2019


== Series Details ==

Series: series starting with [01/28] drm/i915: Leave the aliasing-ppgtt size alone
URL   : https://patchwork.freedesktop.org/series/69111/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e71bdbad4df9 drm/i915: Leave the aliasing-ppgtt size alone
d9b14a009b12 drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY under a separate Kconfig
9028f0700794 drm: Expose a method for creating anonymous struct file around drm_minor
d17f4ba5f510 drm/i915/selftests: Replace mock_file hackery with drm's true fake
3936950ebcc3 drm/i915/selftests: Wrap vm_mmap() around GEM objects
-:41: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#41: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:698:
+#define expand32(x) (((x) << 0) | ((x) << 8) | ((x) << 16) | ((x) << 24))

-:94: ERROR:SPACING: space required before that '*' (ctx:VxV)
#94: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:751:
+		u32 __user *ux = u64_to_user_ptr((u64)(addr + i * sizeof*(ux)));
 		                                                        ^

-:150: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#150: 
new file mode 100644

-:155: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#155: FILE: drivers/gpu/drm/i915/selftests/igt_mmap.c:1:
+/*

-:156: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#156: FILE: drivers/gpu/drm/i915/selftests/igt_mmap.c:2:
+ * SPDX-License-Identifier: MIT

-:200: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#200: FILE: drivers/gpu/drm/i915/selftests/igt_mmap.h:1:
+/*

-:201: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#201: FILE: drivers/gpu/drm/i915/selftests/igt_mmap.h:2:
+ * SPDX-License-Identifier: MIT

total: 1 errors, 5 warnings, 1 checks, 183 lines checked
1d1a839d0eee drm/i915/selftests: Verify mmap_gtt revocation on unbinding
-:67: WARNING:LINE_SPACING: Missing a blank line after declarations
#67: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:840:
+		int err = __get_user(c, addr);
+		if (err)

total: 0 errors, 1 warnings, 0 checks, 122 lines checked
ceea830679d3 drm/i915/userptr: Try to acquire the page lock around set_page_dirty()
-:29: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#29: 
References: cb6d7c7dc7ff ("drm/i915/userptr: Acquire the page lock around set_page_dirty()")

-:29: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit cb6d7c7dc7ff ("drm/i915/userptr: Acquire the page lock around set_page_dirty()")'
#29: 
References: cb6d7c7dc7ff ("drm/i915/userptr: Acquire the page lock around set_page_dirty()")

-:30: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 505a8ec7e11a ("Revert "drm/i915/userptr: Acquire the page lock around set_page_dirty()"")'
#30: 
References: 505a8ec7e11a ("Revert "drm/i915/userptr: Acquire the page lock around set_page_dirty()"")

-:31: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6dcc693bc57f ("ext4: warn when page is dirtied without buffers")'
#31: 
References: 6dcc693bc57f ("ext4: warn when page is dirtied without buffers")

total: 3 errors, 1 warnings, 0 checks, 29 lines checked
a45e61eacae2 drm/i915/gem: Safely acquire the ctx->vm when copying
9bdc24450d64 drm/i915/selftests: Exercise parallel blit operations on a single ctx
c3c94d80b0d4 drm/i915/selftests: Perform some basic cycle counting of MI ops
-:448: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#448: 
new file mode 100644

-:487: ERROR:BRACKET_SPACE: space prohibited before open square bracket '['
#487: FILE: drivers/gpu/drm/i915/selftests/i915_selftest.c:87:
+#define selftest(n, f) [perf_##n] = { .name = #n, { .live = f } },

-:491: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#491: FILE: drivers/gpu/drm/i915/selftests/i915_selftest.c:91:
+};
+#undef selftest

-:502: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#502: FILE: drivers/gpu/drm/i915/selftests/i915_selftest.c:110:
+#define selftest_0(n, func, id) \
+module_param_named(id, perf_selftests[perf_##n].enabled, bool, 0400);

total: 1 errors, 2 warnings, 1 checks, 492 lines checked
f45bb1d594d3 drm/i915/selftests: Mock the engine sorting for easy validation
-:27: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

-:32: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#32: FILE: drivers/gpu/drm/i915/gt/selftest_engine_user.c:1:
+/*

-:33: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#33: FILE: drivers/gpu/drm/i915/gt/selftest_engine_user.c:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 3 warnings, 0 checks, 102 lines checked
38d867cf57b7 drm/i915: Use a ctor for TYPESAFE_BY_RCU i915_request
232c6ba6f6cb drm/i915: Drop GEM context as a direct link from i915_request
3a0ae3067bf8 drm/i915: Push the use-semaphore marker onto the intel_context
ef490f1068ef drm/i915: Remove i915->kernel_context
ba1f4fa59b4d drm/i915: Move i915_gem_init_contexts() earlier
ed2a59aa0cbe drm/i915/gt: Defer engine registration until fully initialised
b9609375b36f drm/i915/gt: Pull GT initialisation under intel_gt_init()
5f4d629c031a drm/i915/gt: Merge engine init/setup loops
4160e0503723 drm/i915/gt: Expose engine properties via sysfs
-:87: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#87: 
new file mode 100644

-:92: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#92: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.c:1:
+/*

-:93: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#93: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.c:2:
+ * SPDX-License-Identifier: MIT

-:192: CHECK:SPACING: No space is necessary after a cast
#192: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.c:101:
+			 show_unknown ? BITS_PER_TYPE(typeof(caps)) : count) {

-:306: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#306: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.h:1:
+/*

-:307: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#307: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 1 checks, 254 lines checked
a32d1f3858a7 drm/i915/gt: Expose engine->mmio_base via sysfs
93bc45f82e4e drm/i915/gt: Expose timeslice duration to sysfs
19a804a63832 drm/i915/gt: Expose reset stop timeout via sysfs
c6eecb05f917 drm/i915/gt: Expose preempt reset timeout via sysfs
af1612f2566e drm/i915/gt: Expose heartbeat interval via sysfs
283e024b8f15 drm/i915: Flush idle barriers when waiting
a1168952d552 drm/i915: Allow userspace to specify ringsize on construction
8fb45813b7e1 drm/i915/gem: Honour O_NONBLOCK before throttling execbuf submissions



More information about the Intel-gfx mailing list