[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Refactor Gen11+ SAGV support (rev9)
Patchwork
patchwork at emeril.freedesktop.org
Thu Nov 7 12:05:55 UTC 2019
== Series Details ==
Series: Refactor Gen11+ SAGV support (rev9)
URL : https://patchwork.freedesktop.org/series/68028/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
96e43a266578 drm/i915: Refactor intel_can_enable_sagv
-:191: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#191: FILE: drivers/gpu/drm/i915/intel_pm.c:3835:
+ for_each_new_intel_crtc_in_state(state, crtc,
+ new_crtc_state, i) {
-:271: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#271: FILE: drivers/gpu/drm/i915/intel_pm.c:3915:
+ bool state_sagv_masked = \
-:276: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#276: FILE: drivers/gpu/drm/i915/intel_pm.c:3920:
+ bool sagv_masked = \
-:311: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#311: FILE: drivers/gpu/drm/i915/intel_pm.c:4341:
+tgl_check_pipe_fits_sagv_wm(struct intel_crtc_state *crtc_state,
+ struct skl_ddb_allocation *ddb /* out */)
-:423: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#423: FILE: drivers/gpu/drm/i915/intel_pm.c:4991:
+ skl_compute_plane_wm(crtc_state, 0, latency,
+ wm_params, &levels[0],
-:425: CHECK:BRACES: Unbalanced braces around else statement
#425: FILE: drivers/gpu/drm/i915/intel_pm.c:4993:
+ } else
-:427: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#427: FILE: drivers/gpu/drm/i915/intel_pm.c:4995:
+ memcpy(&plane_wm->sagv_wm0, &levels[0],
+ sizeof(struct skl_wm_level));
-:490: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#490: FILE: drivers/gpu/drm/i915/intel_pm.c:5681:
+ for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
+ new_crtc_state, i) {
-:496: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#496: FILE: drivers/gpu/drm/i915/intel_pm.c:5687:
+ struct skl_plane_wm *plane_wm = \
-:519: WARNING:LINE_SPACING: Missing a blank line after declarations
#519: FILE: drivers/gpu/drm/i915/intel_pm.c:5710:
+ int pipe_bit = BIT(crtc->pipe);
+ state->crtc_sagv_mask |= pipe_bit;
total: 0 errors, 4 warnings, 6 checks, 454 lines checked
30fbd29899ff drm/i915: Restrict qgv points which don't have enough bandwidth.
-:127: CHECK:LINE_SPACING: Please don't use multiple blank lines
#127: FILE: drivers/gpu/drm/i915/display/intel_bw.c:139:
+
+
-:233: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#233: FILE: drivers/gpu/drm/i915/display/intel_bw.c:484:
+ if (!intel_can_enable_sagv(state)) {
+
-:408: CHECK:BRACES: braces {} should be used on all arms of this statement
#408: FILE: drivers/gpu/drm/i915/display/intel_display.c:14965:
+ if (INTEL_GEN(dev_priv) < 11) {
[...]
+ } else
[...]
-:411: CHECK:BRACES: Unbalanced braces around else statement
#411: FILE: drivers/gpu/drm/i915/display/intel_display.c:14968:
+ } else
total: 0 errors, 0 warnings, 4 checks, 486 lines checked
More information about the Intel-gfx
mailing list