[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Enable second dbuf slice for ICL and TGL

Patchwork patchwork at emeril.freedesktop.org
Thu Nov 7 17:40:26 UTC 2019


== Series Details ==

Series: drm/i915: Enable second dbuf slice for ICL and TGL
URL   : https://patchwork.freedesktop.org/series/69124/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2fdfc3b51c5b drm/i915: Enable second dbuf slice for ICL and TGL
-:221: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 0)
#221: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:311:
 	for ((wf) = intel_display_power_get((i915), (domain)); (wf); \
[...]
+u8 intel_dbuf_max_slices(struct drm_i915_private *dev_priv);

-:467: WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations
#467: FILE: drivers/gpu/drm/i915/intel_pm.c:3953:
+		u32 pipe_dbuf_slice_mask = \

-:469: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#469: FILE: drivers/gpu/drm/i915/intel_pm.c:3955:
+			i915_get_allowed_dbuf_mask(dev_priv,
+						pipe,

-:585: CHECK:LINE_SPACING: Please don't use multiple blank lines
#585: FILE: drivers/gpu/drm/i915/intel_pm.c:4303:
+
+

-:589: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#589: FILE: drivers/gpu/drm/i915/intel_pm.c:4307:
+	DRM_DEBUG_KMS("Pipe %d downscale amount %d.%d\n",
+		       crtc->pipe, pipe_downscale.val >> 16,

-:608: CHECK:LINE_SPACING: Please don't use multiple blank lines
#608: FILE: drivers/gpu/drm/i915/intel_pm.c:4326:
+
+

-:609: CHECK:CAMELCASE: Avoid CamelCase: <DBuf1>
#609: FILE: drivers/gpu/drm/i915/intel_pm.c:4327:
+#define ICL_PIPE_A_DBUF_SLICES(DBuf1)  \

-:617: CHECK:CAMELCASE: Avoid CamelCase: <DBuf2>
#617: FILE: drivers/gpu/drm/i915/intel_pm.c:4335:
+#define ICL_PIPE_AB_DBUF_SLICES(DBuf1, DBuf2)   \

-:629: CHECK:CAMELCASE: Avoid CamelCase: <DBuf3>
#629: FILE: drivers/gpu/drm/i915/intel_pm.c:4347:
+#define ICL_PIPE_ABC_DBUF_SLICES(DBuf1, DBuf2, DBuf3)  \

-:639: CHECK:CAMELCASE: Avoid CamelCase: <DBuf4>
#639: FILE: drivers/gpu/drm/i915/intel_pm.c:4357:
+#define ICL_PIPE_ABCD_DBUF_SLICES(DBuf1, DBuf2, DBuf3, DBuf4)  \

-:748: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#748: FILE: drivers/gpu/drm/i915/intel_pm.c:4466:
+u32 i915_get_allowed_dbuf_mask(struct drm_i915_private *dev_priv,
+				      int pipe, u32 active_pipes,

total: 0 errors, 2 warnings, 9 checks, 680 lines checked



More information about the Intel-gfx mailing list