[Intel-gfx] [PATCH 1/3] drm/i915/display: Fix TRANS_DDI_MST_TRANSPORT_SELECT definition

Lucas De Marchi lucas.demarchi at intel.com
Thu Nov 7 22:29:30 UTC 2019


On Thu, Nov 07, 2019 at 01:45:57PM -0800, Jose Souza wrote:
>TRANS_DDI_MST_TRANSPORT_SELECT is 2 bits wide not 3, it was taking
>one bit from EDP/DSI Input Select.
>
>Fixes: b3545e086877 ("drm/i915/tgl: add support to one DP-MST stream")
>Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>Signed-off-by: José Roberto de Souza <jose.souza at intel.com>

ugh, facepalm

Double checked that it matches the spec.

Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

thanks
Lucas De Marchi

>---
> drivers/gpu/drm/i915/i915_reg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
>index a607ea520829..70459a3d93e3 100644
>--- a/drivers/gpu/drm/i915/i915_reg.h
>+++ b/drivers/gpu/drm/i915/i915_reg.h
>@@ -9665,7 +9665,7 @@ enum skl_power_gate {
> #define  TRANS_DDI_EDP_INPUT_A_ONOFF	(4 << 12)
> #define  TRANS_DDI_EDP_INPUT_B_ONOFF	(5 << 12)
> #define  TRANS_DDI_EDP_INPUT_C_ONOFF	(6 << 12)
>-#define  TRANS_DDI_MST_TRANSPORT_SELECT_MASK	REG_GENMASK(12, 10)
>+#define  TRANS_DDI_MST_TRANSPORT_SELECT_MASK	REG_GENMASK(11, 10)
> #define  TRANS_DDI_MST_TRANSPORT_SELECT(trans)	\
> 	REG_FIELD_PREP(TRANS_DDI_MST_TRANSPORT_SELECT_MASK, trans)
> #define  TRANS_DDI_HDCP_SIGNALLING	(1 << 9)
>-- 
>2.24.0
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx at lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list