[Intel-gfx] [PATCH] drm/i915: Protect context while grabbing its name for the request

Chris Wilson chris at chris-wilson.co.uk
Mon Nov 11 10:51:27 UTC 2019


Quoting Mika Kuoppala (2019-11-11 10:25:00)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > Inside print_request(), we query the context/timeline name. Nothing
> > immediately protects the context from being freed if the request is
> > complete -- we rely on serialisation by the caller to keep the name
> > valid until they finish using it. Inside intel_engine_dump(), we
> > generally only print the requsts in the execution queue protected by the
> requests
> 
> > engine->active.lock, but we also show the pending execlists ports which
> > are not protected and so require an rcu_read_lock to keep the pointer
> > valid.
> 
> s/an/a ?

Interesting. I used an because I pronounce it R C U read_lock, and since
it then starts with the solitary R takes a vowel sound. English is
bizarre.
-Chris


More information about the Intel-gfx mailing list