[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/27] drm/i915: Flush context free work on cleanup
Patchwork
patchwork at emeril.freedesktop.org
Tue Nov 12 10:12:16 UTC 2019
== Series Details ==
Series: series starting with [01/27] drm/i915: Flush context free work on cleanup
URL : https://patchwork.freedesktop.org/series/69340/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
ac37225d9e6d drm/i915: Flush context free work on cleanup
5f329da2c2b9 drm/i915/gt: Try an extra flush on the Haswell blitter
2064187d1d57 drm/i915/gem: Silence sparse for RCU protection inside the constructor
-:4: WARNING:EMAIL_SUBJECT: A patch subject line should describe the change not the tool that found it
#4:
Subject: [PATCH] drm/i915/gem: Silence sparse for RCU protection inside the
total: 0 errors, 1 warnings, 0 checks, 18 lines checked
a25148dd05d5 drm/i915/selftests: Mock the engine sorting for easy validation
-:27: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#27:
new file mode 100644
-:32: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#32: FILE: drivers/gpu/drm/i915/gt/selftest_engine_user.c:1:
+/*
-:33: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#33: FILE: drivers/gpu/drm/i915/gt/selftest_engine_user.c:2:
+ * SPDX-License-Identifier: MIT
total: 0 errors, 3 warnings, 0 checks, 102 lines checked
66ba34ab657c Revert "drm/i915: use a separate context for gpu relocs"
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11:
References: 8a9a982767b7 ("drm/i915: use a separate context for gpu relocs")
-:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 8a9a982767b7 ("drm/i915: use a separate context for gpu relocs")'
#11:
References: 8a9a982767b7 ("drm/i915: use a separate context for gpu relocs")
-:12: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit c45e788d95b4 ("drm/i915/tgl: Suspend pre-parser across GTT invalidations")'
#12:
References: c45e788d95b4 ("drm/i915/tgl: Suspend pre-parser across GTT invalidations")
total: 2 errors, 1 warnings, 0 checks, 60 lines checked
7e47b7d51b37 drm/i915: Use a ctor for TYPESAFE_BY_RCU i915_request
c71a7e0df434 drm/i915: Drop GEM context as a direct link from i915_request
17b4ecc7c766 drm/i915: Push the use-semaphore marker onto the intel_context
b5213720affe drm/i915: Remove i915->kernel_context
1e54ab29f387 drm/i915: Move i915_gem_init_contexts() earlier
122c7900a027 drm/i915/uc: Use an internal buffer for firmware images
6b0f1210c90e drm/i915/gt: Pull GT initialisation under intel_gt_init()
8363e750fa11 drm/i915/gt: Merge engine init/setup loops
45ff81a774f0 drm/i915/gt: Expose engine properties via sysfs
-:87: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#87:
new file mode 100644
-:92: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#92: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.c:1:
+/*
-:93: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#93: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.c:2:
+ * SPDX-License-Identifier: MIT
-:192: CHECK:SPACING: No space is necessary after a cast
#192: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.c:101:
+ show_unknown ? BITS_PER_TYPE(typeof(caps)) : count) {
-:306: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#306: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.h:1:
+/*
-:307: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#307: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.h:2:
+ * SPDX-License-Identifier: MIT
total: 0 errors, 5 warnings, 1 checks, 254 lines checked
57943a58e8c8 drm/i915/gt: Expose engine->mmio_base via sysfs
b62a9b597507 drm/i915/gt: Expose timeslice duration to sysfs
e32133025cb9 drm/i915/gt: Expose busywait duration to sysfs
e0567653feb7 drm/i915/gt: Expose reset stop timeout via sysfs
69fa79e81bab drm/i915/gt: Expose preempt reset timeout via sysfs
29e20339310f drm/i915/gt: Expose heartbeat interval via sysfs
b41a1699500b drm/i915: Flush idle barriers when waiting
40c64ae51c38 drm/i915: Allow userspace to specify ringsize on construction
6644f1fa3d89 drm/i915/gem: Honour O_NONBLOCK before throttling execbuf submissions
8e05e23d778a drm/i915/gt: Set unused mocs entry to follow PTE on tgl as on all others
a9f1cb953bee drm/i915/gt: Tidy up debug-warns for the mocs control table
f69d2f9c2ffe drm/i915/gt: Refactor mocs loops into single control macro
-:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse 't' - possible side-effects?
#66: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:345:
+#define for_each_mocs(mocs, t, i) \
+ for (i = 0; \
+ i < t->n_entries ? (mocs = get_entry_control(t, i)), 1 : 0;\
+ i++)
-:66: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 't' may be better as '(t)' to avoid precedence issues
#66: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:345:
+#define for_each_mocs(mocs, t, i) \
+ for (i = 0; \
+ i < t->n_entries ? (mocs = get_entry_control(t, i)), 1 : 0;\
+ i++)
-:66: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#66: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:345:
+#define for_each_mocs(mocs, t, i) \
+ for (i = 0; \
+ i < t->n_entries ? (mocs = get_entry_control(t, i)), 1 : 0;\
+ i++)
-:128: CHECK:MACRO_ARG_REUSE: Macro argument reuse 't' - possible side-effects?
#128: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:400:
+#define for_each_l3cc(l3cc, t, i) \
+ for (i = 0; \
+ i < (t->n_entries + 1) / 2 ? \
+ (l3cc = l3cc_combine(get_entry_l3cc(t, 2 * i), \
+ get_entry_l3cc(t, 2 * i + 1))), 1 : \
+ 0; \
+ i++)
-:128: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 't' may be better as '(t)' to avoid precedence issues
#128: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:400:
+#define for_each_l3cc(l3cc, t, i) \
+ for (i = 0; \
+ i < (t->n_entries + 1) / 2 ? \
+ (l3cc = l3cc_combine(get_entry_l3cc(t, 2 * i), \
+ get_entry_l3cc(t, 2 * i + 1))), 1 : \
+ 0; \
+ i++)
-:128: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#128: FILE: drivers/gpu/drm/i915/gt/intel_mocs.c:400:
+#define for_each_l3cc(l3cc, t, i) \
+ for (i = 0; \
+ i < (t->n_entries + 1) / 2 ? \
+ (l3cc = l3cc_combine(get_entry_l3cc(t, 2 * i), \
+ get_entry_l3cc(t, 2 * i + 1))), 1 : \
+ 0; \
+ i++)
total: 0 errors, 0 warnings, 6 checks, 187 lines checked
b49d5164957c drm/i915/selftests: Add coverage of mocs registers
-:30: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#30:
new file mode 100644
-:35: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#35: FILE: drivers/gpu/drm/i915/gt/selftest_mocs.c:1:
+/*
-:36: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#36: FILE: drivers/gpu/drm/i915/gt/selftest_mocs.c:2:
+ * SPDX-License-Identifier: MIT
total: 0 errors, 3 warnings, 0 checks, 405 lines checked
More information about the Intel-gfx
mailing list