[Intel-gfx] [PATCH v3 2/2] drm/i915/tgl: MOCS table update

Francisco Jerez currojerez at riseup.net
Tue Nov 12 23:20:03 UTC 2019


Matt Roper <matthew.d.roper at intel.com> writes:

> The bspec was just updated with a minor correction to entry 61 (it
> shouldn't have had the SCF bit set).
>
> v2:
>  - Add a MOCS_ENTRY_UNUSED() and use it to declare the
>    explicitly-reserved MOCS entries. (Lucas)
>  - Move the warning suppression from the Makefile to a #pragma that only
>    affects the TGL table. (Lucas)
>
> v3:
>  - Entries 16 and 17 are identical to ICL now, so no need to explicitly
>    adjust them (or mess with compiler warning overrides).
>
> Bspec: 45101
> Fixes: 2ddf992179c4 ("drm/i915/tgl: Define MOCS entries for Tigerlake")
> Cc: Tomasz Lis <tomasz.lis at intel.com>
> Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> Cc: Francisco Jerez <francisco.jerez.plata at intel.com>
> Cc: Jon Bloomfield <jon.bloomfield at intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper at intel.com>

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

> ---
>  drivers/gpu/drm/i915/gt/intel_mocs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_mocs.c b/drivers/gpu/drm/i915/gt/intel_mocs.c
> index 06e2adbf27be..2b977991b785 100644
> --- a/drivers/gpu/drm/i915/gt/intel_mocs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_mocs.c
> @@ -263,7 +263,7 @@ static const struct drm_i915_mocs_entry tigerlake_mocs_table[] = {
>  		   L3_1_UC),
>  	/* HW Special Case (Displayable) */
>  	MOCS_ENTRY(61,
> -		   LE_1_UC | LE_TC_1_LLC | LE_SCF(1),
> +		   LE_1_UC | LE_TC_1_LLC,
>  		   L3_3_WB),
>  };
>  
> -- 
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20191112/9f060f7e/attachment.sig>


More information about the Intel-gfx mailing list