[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/11] HAX to make DSC work on the icelake test system

Patchwork patchwork at emeril.freedesktop.org
Thu Nov 14 17:04:13 UTC 2019 

== Series Details ==

Series: series starting with [01/11] HAX to make DSC work on the icelake test system
URL   : https://patchwork.freedesktop.org/series/69478/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e129b15e0bb7 HAX to make DSC work on the icelake test system
9c348f274288 drm/i915: Remove hw.mode
1d5ae5be65dc drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:185: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#185: FILE: drivers/gpu/drm/i915/display/intel_display.c:12640:
+	crtc_state->hw.pipe_mode = crtc_state->hw.adjusted_mode = crtc_state->uapi.adjusted_mode;

total: 0 errors, 1 warnings, 1 checks, 452 lines checked
dfd57bb0186c drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3.
0dfc33b4c96e drm/i915: Try to make bigjoiner work in atomic check, v3.
-:141: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#141: FILE: drivers/gpu/drm/i915/display/intel_display.c:12654:
+		from_crtc_state = intel_atomic_get_new_crtc_state(state,
+					crtc_state->bigjoiner_linked_crtc);

-:200: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#200: FILE: drivers/gpu/drm/i915/display/intel_display.c:12724:
+	crtc_state->nv12_planes = crtc_state->c8_planes = crtc_state->update_planes = 0;

-:294: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#294: FILE: drivers/gpu/drm/i915/display/intel_display.c:14192:
+	slave = new_crtc_state->bigjoiner_linked_crtc =

-:322: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#322: FILE: drivers/gpu/drm/i915/display/intel_display.c:14220:
+		intel_atomic_get_crtc_state(&state->base,
+			master_crtc_state->bigjoiner_linked_crtc);

-:327: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#327: FILE: drivers/gpu/drm/i915/display/intel_display.c:14225:
+	slave_crtc_state->bigjoiner = master_crtc_state->bigjoiner = false;

-:328: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#328: FILE: drivers/gpu/drm/i915/display/intel_display.c:14226:
+	slave_crtc_state->bigjoiner_slave = master_crtc_state->bigjoiner_slave = false;

-:329: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#329: FILE: drivers/gpu/drm/i915/display/intel_display.c:14227:
+	slave_crtc_state->bigjoiner_linked_crtc = master_crtc_state->bigjoiner_linked_crtc = NULL;

-:391: ERROR:OPEN_BRACE: that open brace { should be on the previous line
#391: FILE: drivers/gpu/drm/i915/display/intel_display.c:14503:
+	if (new_crtc_state->bigjoiner)
+		{/* Not supported yet */}

total: 1 errors, 0 warnings, 7 checks, 406 lines checked
4221707d255e drm/i915: Enable big joiner support in enable and disable sequences.
-:107: WARNING:LONG_LINE_COMMENT: line over 100 characters
#107: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:4364:
+		 /* Our own transcoder needs to be disabled when reading it in intel_ddi_read_func_ctl() */

-:109: WARNING:LONG_LINE: line over 100 characters
#109: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:4366:
+		pipe_config->cpu_transcoder = (enum transcoder)pipe_config->bigjoiner_linked_crtc->pipe;

-:222: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#222: FILE: drivers/gpu/drm/i915/display/intel_display.c:6664:
+			I915_WRITE(PIPE_MULT(cpu_transcoder),
+				  pipe_config->pixel_multiplier - 1);

-:230: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#230: FILE: drivers/gpu/drm/i915/display/intel_display.c:6668:
+			intel_cpu_transcoder_set_m_n(pipe_config,
+						    &pipe_config->fdi_m_n, NULL);

-:317: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#317: FILE: drivers/gpu/drm/i915/display/intel_display.c:7635:
+		/*
+		  * transcoder is programmed to the full mode,

-:536: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#536: FILE: drivers/gpu/drm/i915/display/intel_display.c:13459:
+	if (!PIPE_CONF_QUIRK(PIPE_CONFIG_QUIRK_BIGJOINER_SLAVE)) {
 	PIPE_CONF_CHECK_X(dpll_hw_state.dpll);

-:745: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#745: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:824:
+#define PIPE_CONFIG_QUIRK_BIGJOINER_SLAVE	(1<<1) /* bigjoiner slave, partial readout */
                                          	  ^

total: 0 errors, 4 warnings, 3 checks, 914 lines checked
ed66bbff27f8 drm/i915: Make hardware readout work on i915.
-:73: WARNING:LONG_LINE: line over 100 characters
#73: FILE: drivers/gpu/drm/i915/display/intel_display.c:10198:
+		    (I915_READ(PLANE_SURF(bigjoiner_pipe, plane_id)) & 0xfffff000) == plane_config->base) {

-:74: WARNING:LONG_LINE: line over 100 characters
#74: FILE: drivers/gpu/drm/i915/display/intel_display.c:10199:
+			val = I915_READ(PLANE_SIZE(crtc_state->bigjoiner_linked_crtc->pipe, plane_id));

-:136: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#136: FILE: drivers/gpu/drm/i915/display/intel_display.c:17948:
+				/*
+				* FIXME don't have the fb yet, so can't

total: 0 errors, 3 warnings, 0 checks, 119 lines checked
79dd9ad5168d drm/i915: Link planes in a bigjoiner configuration, v3.
-:66: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#66: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:231:
+			intel_atomic_get_new_plane_state(state,
+				new_plane_state->bigjoiner_plane);

-:296: WARNING:LONG_LINE: line over 100 characters
#296: FILE: drivers/gpu/drm/i915/display/intel_display.c:12222:
+		for_each_oldnew_intel_plane_in_state(state, plane, old_plane_state, new_plane_state, i) {

-:358: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#358: FILE: drivers/gpu/drm/i915/display/intel_display.c:12342:
+				intel_atomic_get_new_plane_state(state,
+					plane_state->bigjoiner_plane);

-:431: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#431: FILE: drivers/gpu/drm/i915/display/intel_display.h:458:
+		for_each_if ((((plane_state) = \

-:432: WARNING:LONG_LINE: line over 100 characters
#432: FILE: drivers/gpu/drm/i915/display/intel_display.h:459:
+			      to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &iter->base))), \

-:433: WARNING:LONG_LINE: line over 100 characters
#433: FILE: drivers/gpu/drm/i915/display/intel_display.h:460:
+			      ((plane) = (plane_state)->bigjoiner_slave ? (plane_state)->bigjoiner_plane : (iter)), \

-:435: WARNING:LONG_LINE: line over 100 characters
#435: FILE: drivers/gpu/drm/i915/display/intel_display.h:462:
+				to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &plane->base)) : \

total: 0 errors, 5 warnings, 2 checks, 463 lines checked
c9a540d85b32 drm/i915: Add bigjoiner aware plane clipping checks
c76daafe3429 drm/i915: Add intel_update_bigjoiner handling.
fac798935da8 drm/i915: Add debugfs dumping for bigjoiner, v2.
-:71: WARNING:LONG_LINE: line over 100 characters
#71: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2626:
+		seq_printf(m, "\t--Plane id %d: type=%s, %s, clipped crtc="DRM_RECT_FMT", clipped src="DRM_RECT_FP_FMT", format=%s, rotation=%s\n",

-:71: CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#71: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2626:
+		seq_printf(m, "\t--Plane id %d: type=%s, %s, clipped crtc="DRM_RECT_FMT", clipped src="DRM_RECT_FP_FMT", format=%s, rotation=%s\n",

total: 0 errors, 1 warnings, 1 checks, 80 lines checked

More information about the Intel-gfx mailing list