[Intel-gfx] [PATCH v7] drm/i915: Enable second dbuf slice for ICL and TGL

[Jani Nikula]

On Mon, 18 Nov 2019, "Lisovskiy, Stanislav" <stanislav.lisovskiy at intel.com> wrote:
> I'm fine with fixing checkpatch and sparse failures(even though
> most of those are about 80 line width limitation violation or line
> continuations, which tbh are anyway quite common in our code). 

Please look through the warnings again. Only the COMMIT_LOG_LONG_LINE
one is to be ignored in this case. There's nothing else about 80
character line width. Line continuation is about using backslash to
continue to another line while that's only needed in macros.

Please let's just try to leave the code in neater shape after our
changes. We have these steps in CI so people wouldn't have to nitpick
about them separately.

> One thing I don't get is why this should cause any regression, as both
> BAT and IGT are green here for two runs in a row.
>
> What is the point of having a CI then.

Are you saying there's no point in having CI if it can't catch
absolutely everything?

Our CI is like every other CI everywhere; imperfect. Both in terms of
hardware and software coverage. We would have no bugs reported by the
community otherwise.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center