[Intel-gfx] [V3 4/8] drm/i915/dsi: Add check for periodic command mode
kbuild test robot
lkp at intel.com
Tue Nov 19 20:05:08 UTC 2019
Hi Vandita,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[cannot apply to v5.4-rc8 next-20191118]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Vandita-Kulkarni/Add-support-for-mipi-dsi-cmd-mode/20191120-015713
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp at intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/i915/display/icl_dsi.c: In function 'gen11_dsi_configure_transcoder':
drivers/gpu/drm/i915/display/icl_dsi.c:718:11: error: 'TE_SOURCE_GPIO' undeclared (first use in this function); did you mean 'DP_SOURCE_OUI'?
tmp |= TE_SOURCE_GPIO;
^~~~~~~~~~~~~~
DP_SOURCE_OUI
drivers/gpu/drm/i915/display/icl_dsi.c:718:11: note: each undeclared identifier is reported only once for each function it appears in
drivers/gpu/drm/i915/display/icl_dsi.c: In function 'gen11_dsi_config_util_pin':
drivers/gpu/drm/i915/display/icl_dsi.c:999:10: error: 'UTIL_PIN_DIRECTION_INPUT' undeclared (first use in this function); did you mean 'UTIL_PIN_PIPE_MASK'?
tmp |= UTIL_PIN_DIRECTION_INPUT;
^~~~~~~~~~~~~~~~~~~~~~~~
UTIL_PIN_PIPE_MASK
In file included from drivers/gpu/drm/i915/display/intel_display_types.h:46:0,
from drivers/gpu/drm/i915/display/intel_dsi.h:30,
from drivers/gpu/drm/i915/display/icl_dsi.c:35:
drivers/gpu/drm/i915/display/icl_dsi.c: In function 'gen11_dsi_deconfigure_trancoder':
drivers/gpu/drm/i915/display/icl_dsi.c:1164:20: error: implicit declaration of function 'DSI_CMD_FRMCTL'; did you mean 'DSI_CMD_RXCTL'? [-Werror=implicit-function-declaration]
tmp = I915_READ(DSI_CMD_FRMCTL(port));
^
drivers/gpu/drm/i915/i915_drv.h:1979:45: note: in definition of macro '__I915_REG_OP'
intel_uncore_##op__(&(dev_priv__)->uncore, __VA_ARGS__)
^~~~~~~~~~~
drivers/gpu/drm/i915/display/icl_dsi.c:1164:10: note: in expansion of macro 'I915_READ'
tmp = I915_READ(DSI_CMD_FRMCTL(port));
^~~~~~~~~
drivers/gpu/drm/i915/i915_drv.h:1981:57: error: incompatible type for argument 2 of 'intel_uncore_read'
#define I915_READ(reg__) __I915_REG_OP(read, dev_priv, (reg__))
^
drivers/gpu/drm/i915/i915_drv.h:1979:45: note: in definition of macro '__I915_REG_OP'
intel_uncore_##op__(&(dev_priv__)->uncore, __VA_ARGS__)
^~~~~~~~~~~
drivers/gpu/drm/i915/display/icl_dsi.c:1164:10: note: in expansion of macro 'I915_READ'
tmp = I915_READ(DSI_CMD_FRMCTL(port));
^~~~~~~~~
In file included from drivers/gpu/drm/i915/gt/uc/intel_guc.h:9:0,
from drivers/gpu/drm/i915/gt/uc/intel_uc.h:9,
from drivers/gpu/drm/i915/gt/intel_gt_types.h:16,
from drivers/gpu/drm/i915/i915_drv.h:81,
from drivers/gpu/drm/i915/display/intel_display_types.h:46,
from drivers/gpu/drm/i915/display/intel_dsi.h:30,
from drivers/gpu/drm/i915/display/icl_dsi.c:35:
drivers/gpu/drm/i915/intel_uncore.h:287:22: note: expected 'i915_reg_t {aka struct <anonymous>}' but argument is of type 'int'
static inline u##x__ intel_uncore_##name__(struct intel_uncore *uncore, \
^
drivers/gpu/drm/i915/intel_uncore.h:302:1: note: in expansion of macro '__uncore_read'
__uncore_read(read, 32, l, true)
^~~~~~~~~~~~~
drivers/gpu/drm/i915/display/icl_dsi.c:1165:12: error: 'DSI_PERIODIC_FRAME_UPDATE_ENABLE' undeclared (first use in this function); did you mean 'GEN6_MBCTL_BME_UPDATE_ENABLE'?
tmp &= ~DSI_PERIODIC_FRAME_UPDATE_ENABLE;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
GEN6_MBCTL_BME_UPDATE_ENABLE
In file included from drivers/gpu/drm/i915/display/intel_display_types.h:46:0,
from drivers/gpu/drm/i915/display/intel_dsi.h:30,
from drivers/gpu/drm/i915/display/icl_dsi.c:35:
drivers/gpu/drm/i915/i915_drv.h:1982:65: error: incompatible type for argument 2 of 'intel_uncore_write'
#define I915_WRITE(reg__, val__) __I915_REG_OP(write, dev_priv, (reg__), (val__))
^
drivers/gpu/drm/i915/i915_drv.h:1979:45: note: in definition of macro '__I915_REG_OP'
intel_uncore_##op__(&(dev_priv__)->uncore, __VA_ARGS__)
^~~~~~~~~~~
drivers/gpu/drm/i915/display/icl_dsi.c:1166:4: note: in expansion of macro 'I915_WRITE'
I915_WRITE(DSI_CMD_FRMCTL(port), tmp);
^~~~~~~~~~
In file included from drivers/gpu/drm/i915/gt/uc/intel_guc.h:9:0,
from drivers/gpu/drm/i915/gt/uc/intel_uc.h:9,
from drivers/gpu/drm/i915/gt/intel_gt_types.h:16,
from drivers/gpu/drm/i915/i915_drv.h:81,
from drivers/gpu/drm/i915/display/intel_display_types.h:46,
from drivers/gpu/drm/i915/display/intel_dsi.h:30,
from drivers/gpu/drm/i915/display/icl_dsi.c:35:
drivers/gpu/drm/i915/intel_uncore.h:294:20: note: expected 'i915_reg_t {aka struct <anonymous>}' but argument is of type 'int'
static inline void intel_uncore_##name__(struct intel_uncore *uncore, \
^
drivers/gpu/drm/i915/intel_uncore.h:308:1: note: in expansion of macro '__uncore_write'
__uncore_write(write, 32, l, true)
^~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/icl_dsi.c: In function 'gen11_dsi_is_periodic_cmd_mode':
drivers/gpu/drm/i915/display/icl_dsi.c:1318:16: error: 'DSI_PERIODIC_FRAME_UPDATE_ENABLE' undeclared (first use in this function); did you mean 'GEN6_MBCTL_BME_UPDATE_ENABLE'?
return (val & DSI_PERIODIC_FRAME_UPDATE_ENABLE);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
GEN6_MBCTL_BME_UPDATE_ENABLE
drivers/gpu/drm/i915/display/icl_dsi.c: In function 'gen11_dsi_get_config':
drivers/gpu/drm/i915/display/icl_dsi.c:1341:14: error: 'struct intel_crtc_state' has no member named 'hw'
pipe_config->hw.adjusted_mode.private_flags |=
^~
drivers/gpu/drm/i915/display/icl_dsi.c: In function 'gen11_dsi_compute_config':
drivers/gpu/drm/i915/display/icl_dsi.c:1374:13: error: 'struct intel_crtc_state' has no member named 'hw'
pipe_config->hw.adjusted_mode.private_flags &=
^~
drivers/gpu/drm/i915/display/icl_dsi.c: In function 'gen11_dsi_is_periodic_cmd_mode':
>> drivers/gpu/drm/i915/display/icl_dsi.c:1319:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
cc1: some warnings being treated as errors
vim +1319 drivers/gpu/drm/i915/display/icl_dsi.c
1305
1306 bool gen11_dsi_is_periodic_cmd_mode(struct drm_i915_private *dev_priv,
1307 struct intel_dsi *intel_dsi)
1308 {
1309 u32 val;
1310 enum transcoder dsi_trans;
1311
1312 if (intel_dsi->ports == BIT(PORT_B))
1313 dsi_trans = TRANSCODER_DSI_1;
1314 else
1315 dsi_trans = TRANSCODER_DSI_0;
1316
1317 val = I915_READ(DSI_TRANS_FUNC_CONF(dsi_trans));
1318 return (val & DSI_PERIODIC_FRAME_UPDATE_ENABLE);
> 1319 }
1320
1321 static void gen11_dsi_get_config(struct intel_encoder *encoder,
1322 struct intel_crtc_state *pipe_config)
1323 {
1324 struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
1325 struct intel_crtc *crtc = to_intel_crtc(pipe_config->base.crtc);
1326 struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
1327
1328 /* FIXME: adapt icl_ddi_clock_get() for DSI and use that? */
1329 pipe_config->port_clock =
1330 cnl_calc_wrpll_link(dev_priv, &pipe_config->dpll_hw_state);
1331
1332 pipe_config->base.adjusted_mode.crtc_clock = intel_dsi->pclk;
1333 if (intel_dsi->dual_link)
1334 pipe_config->base.adjusted_mode.crtc_clock *= 2;
1335
1336 gen11_dsi_get_timings(encoder, pipe_config);
1337 pipe_config->output_types |= BIT(INTEL_OUTPUT_DSI);
1338 pipe_config->pipe_bpp = bdw_get_pipemisc_bpp(crtc);
1339
1340 if (gen11_dsi_is_periodic_cmd_mode(dev_priv, intel_dsi))
> 1341 pipe_config->hw.adjusted_mode.private_flags |=
1342 I915_MODE_FLAG_DSI_PERIODIC_CMD_MODE;
1343 }
1344
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 28187 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20191120/687dd796/attachment-0001.gz>
More information about the Intel-gfx
mailing list