[Intel-gfx] [PATCH] drm/i915: Do not initialize display BW when display not available

Ville Syrjälä ville.syrjala at linux.intel.com
Wed Nov 20 10:28:33 UTC 2019


On Tue, Nov 19, 2019 at 05:10:16PM -0800, Stuart Summers wrote:
> When display is not available, finding the memory bandwidth available
> for display is not useful. Skip this sequence here.
> 
> References: HSDES 1209978255
> 
> Signed-off-by: Stuart Summers <stuart.summers at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_bw.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> index 3f6e29f61323..86e75e858008 100644
> --- a/drivers/gpu/drm/i915/display/intel_bw.c
> +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> @@ -264,6 +264,9 @@ static unsigned int icl_max_bw(struct drm_i915_private *dev_priv,
>  
>  void intel_bw_init_hw(struct drm_i915_private *dev_priv)
>  {
> +	if (!HAS_DISPLAY(dev_priv))
> +		return;
> +

It might make sense to catch this somewhere higher up. But seems OK for
now until people figure out what HAS_DISPLAY actually means.

Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

>  	if (IS_GEN(dev_priv, 12))
>  		icl_get_bw_info(dev_priv, &tgl_sa_info);
>  	else if (IS_GEN(dev_priv, 11))
> -- 
> 2.22.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel


More information about the Intel-gfx mailing list