[Intel-gfx] [PATCH 2/2] drm/i915: Remove the timeline as the last step of retiring

Chris Wilson chris at chris-wilson.co.uk
Wed Nov 20 16:12:41 UTC 2019


Quoting Tvrtko Ursulin (2019-11-20 16:07:14)
> 
> On 20/11/2019 15:21, Chris Wilson wrote:
> > Before we remove from the timeline, finish flushing the context state.
> > As the timeline may be peeked upon by another CPU, we don't want to
> > remove request from the timeline until we have finished working on it.
> 
> I have to ask why I'm afraid.

It's the alternative idea to patch 1. If we reorder the code in the
retire, the sanity checks in patch 1 won't notice the inconsistent
state. I think patch 1 is the better expression: if you are dependent on
seeing the post-retirement state, you should wait until that after
retiring.
-Chris


More information about the Intel-gfx mailing list