[Intel-gfx] [PATCH] Revert "drm/i915: disable set/get_tiling ioctl on gen12+"

[Francisco Jerez]

Chris Wilson <chris at chris-wilson.co.uk> writes:

> Restore the DRI2/DRI3 uABI backchannel that was removed by ab016914984e
> ("drm/i915: disable set/get_tiling ioctl on gen12+") before the ABI
> change was agreed upon.
>
> Fixes: ab016914984e ("drm/i915: disable set/get_tiling ioctl on gen12+")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Thanks.  This makes things easier for userspace until the
modifiers-based alternative to this is in better shape.

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

> ---
>  drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c
> index 1fa592d82af5..39f3bd5defd6 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_tiling.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_tiling.c
> @@ -317,14 +317,10 @@ int
>  i915_gem_set_tiling_ioctl(struct drm_device *dev, void *data,
>  			  struct drm_file *file)
>  {
> -	struct drm_i915_private *dev_priv = to_i915(dev);
>  	struct drm_i915_gem_set_tiling *args = data;
>  	struct drm_i915_gem_object *obj;
>  	int err;
>  
> -	if (!dev_priv->ggtt.num_fences)
> -		return -EOPNOTSUPP;
> -
>  	obj = i915_gem_object_lookup(file, args->handle);
>  	if (!obj)
>  		return -ENOENT;
> @@ -405,9 +401,6 @@ i915_gem_get_tiling_ioctl(struct drm_device *dev, void *data,
>  	struct drm_i915_gem_object *obj;
>  	int err = -ENOENT;
>  
> -	if (!dev_priv->ggtt.num_fences)
> -		return -EOPNOTSUPP;
> -
>  	rcu_read_lock();
>  	obj = i915_gem_object_lookup_rcu(file, args->handle);
>  	if (obj) {
> -- 
> 2.24.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20191121/2e83785e/attachment-0001.sig>