[Intel-gfx] [PATCH] drm/i915/selftests: Shorten infinite wait for sseu

Summers, Stuart stuart.summers at intel.com
Fri Nov 22 01:58:49 UTC 2019


On Thu, 2019-11-21 at 23:30 +0000, Chris Wilson wrote:
> Use our more regular igt_flush_test() to bind the wait-for-idle and
> error out instead of waiting around forever on critical failure.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Yeah, seems like a better approach here. Should we just be passing gt
to that though? Doesn't look like we actually use the private data
outside of that. Of course that's completely unrelated to this change.

Reviewed-by: Stuart Summers <stuart.summers at intel.com>

> ---
>  drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> index f1ce5f64b221..e1d8ccd11409 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> @@ -1168,8 +1168,7 @@ __sseu_finish(const char *name,
>  		igt_spinner_end(spin);
>  
>  	if ((flags & TEST_IDLE) && ret == 0) {
> -		ret = intel_gt_wait_for_idle(ce->engine->gt,
> -					     MAX_SCHEDULE_TIMEOUT);
> +		ret = igt_flush_test(ce->engine->i915);
>  		if (ret)
>  			return ret;
>  
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3270 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20191122/f056e12d/attachment.bin>


More information about the Intel-gfx mailing list