[Intel-gfx] [PATCH] drm/i915/ggtt: Move ballooning support to i915_ggtt

Chris Wilson chris at chris-wilson.co.uk
Mon Nov 25 11:30:39 UTC 2019


Quoting Jani Nikula (2019-11-25 10:51:53)
> On Thu, 21 Nov 2019, Michal Wajdeczko <michal.wajdeczko at intel.com> wrote:
> > Today VGT implements GGTT ballooning on its own, using some private
> > static structure to hold info about reserved GGTT nodes and then
> > manually update vm.reserved size owned by i915_ggtt.
> >
> > As i915_ggtt already manages some custom reserved nodes (like uc_fw)
> > move VGT ballooning support to i915_ggtt and make it more generic
> > for possible future reuse in other scenarios.
> >
> > As a bonus we can drop another place in driver that uses static data.
> >
> > Signed-off-by: Michal Wajdeczko <michal.wajdeczko at intel.com>
> > Cc: Xiong Zhang <xiong.y.zhang at intel.com>
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Jani Nikula <jani.nikula at intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_gem_gtt.c | 47 +++++++++++++++++++
> >  drivers/gpu/drm/i915/i915_gem_gtt.h | 18 ++++++++
> 
> Maybe not part of this patch, but should we start moving this stuff out
> of the top level instead of addming more?

It's on my todo list to split this between the HW pagetable management and
GEM and other interfaces on top.
-Chris


More information about the Intel-gfx mailing list