[Intel-gfx] [PATCH 1/2] drm/i915/dp: fix DP audio for PORT_A on gen12+

Kai Vehmanen kai.vehmanen at linux.intel.com
Mon Nov 25 12:54:11 UTC 2019


Hi,

On Fri, 22 Nov 2019, Ville Syrjälä wrote:

> > -	if (IS_G4X(dev_priv) || port == PORT_A)
> > +	if (IS_G4X(dev_priv) || (INTEL_GEN(dev_priv) < 12 && port == PORT_A))
> 
> Getting a bit messy.
> 
> Hoovering that into something like
> static bool intel_dp_port_has_audio(struct intel_encoder *encoder);
> or
> static bool intel_dp_port_has_audio(struct drm_i915_private *dev_priv, enum port port);
> might be nice.

thanks for the review! I went for the latter option in the v2 I just
sent out.

Br, Kai


More information about the Intel-gfx mailing list