[Intel-gfx] [PATCH] drm/i915/execlists: Fixup cancel_port_requests()

Andi Shyti andi.shyti at intel.com
Mon Nov 25 13:13:56 UTC 2019


Hi Chris,

>  	/* Mark the end of active before we overwrite *active */
> -	WRITE_ONCE(execlists->active, execlists->pending);
> -
> -	for (port = execlists->active; (rq = *port); port++)
> -		execlists_schedule_out(rq);
> -	execlists->active =
> -		memset(execlists->inflight, 0, sizeof(execlists->inflight));
> +	for (port = xchg(&execlists->active, execlists->pending); *port; port++)
> +		execlists_schedule_out(*port);
> +	WRITE_ONCE(execlists->active,
> +		   memset(execlists->inflight, 0, sizeof(execlists->inflight)));

Reviewed-by: Andi Shyti <andi.shyti at intel.com>

Andi


More information about the Intel-gfx mailing list