[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Dynamic EU configuration of Slice/Sub-slice/EU (rev3)

Patchwork patchwork at emeril.freedesktop.org
Tue Nov 26 04:18:38 UTC 2019


== Series Details ==

Series: Dynamic EU configuration of Slice/Sub-slice/EU (rev3)
URL   : https://patchwork.freedesktop.org/series/69980/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f552a3f6fc86 drm/i915: Get active pending request for given context
97da0e00344a drm/i915: set optimum eu/slice/sub-slice configuration based on load type
-:52: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#52: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:717:
+	ctx->subslice_cnt = hweight8(

-:60: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#60: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:725:
+void i915_gem_context_set_load_type(struct i915_gem_context *ctx,
+					enum gem_load_type type)

-:86: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#86: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.h:181:
+void i915_gem_context_set_load_type(struct i915_gem_context *ctx,
+				enum gem_load_type type);

-:187: ERROR:SPACING: space required before the open parenthesis '('
#187: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:2485:
+		if(engine->i915->predictive_load_enable) {

-:277: CHECK:SPACING: No space is necessary after a cast
#277: FILE: drivers/gpu/drm/i915/intel_device_info.c:1033:
+		opt_config = (struct i915_sseu_optimum_config *) chv_config;

total: 1 errors, 0 warnings, 4 checks, 242 lines checked
4b6da705f2ac drm/i915: Predictive governor to control slice/subslice/eu
-:23: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#23: 
 * Fix data type and initialization of mutex to protect predictive load state.

-:50: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

-:55: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#55: FILE: drivers/gpu/drm/i915/gt/intel_deu.c:1:
+/*

-:112: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#112: FILE: drivers/gpu/drm/i915/gt/intel_deu.c:58:
+	list_for_each_entry(ctx, &dev_priv->gem.contexts.list, link) {
+

-:133: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#133: FILE: drivers/gpu/drm/i915/gt/intel_deu.c:79:
+	hrtimer_forward_now(hrtimer,
+			ms_to_ktime(dev_priv->predictive_load_enable));

-:142: WARNING:TYPO_SPELLING: 'fuction' may be misspelled - perhaps 'function'?
#142: FILE: drivers/gpu/drm/i915/gt/intel_deu.c:88:
+ * This fuction is called at driver load

-:153: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#153: FILE: drivers/gpu/drm/i915/gt/intel_deu.c:99:
+			hrtimer_start_range_ns(&dev_priv->pred_timer,
+			ms_to_ktime(dev_priv->predictive_load_enable),

-:166: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#166: FILE: drivers/gpu/drm/i915/gt/intel_deu.h:1:
+#ifndef __INTEL_DEU_H__

-:191: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#191: FILE: drivers/gpu/drm/i915/i915_drv.h:1773:
+extern enum hrtimer_restart predictive_load_cb(struct hrtimer *hrtimer);

-:227: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#227: FILE: drivers/gpu/drm/i915/i915_params.c:105:
+i915_param_named_unsafe(deu_enable, int, 0600,
+	"Enable dynamic EU control for power savings "

total: 0 errors, 5 warnings, 5 checks, 169 lines checked



More information about the Intel-gfx mailing list