[Intel-gfx] [PATCH] drm/i915: unmap the correct pointer in i915_error_object_create()

Chris Wilson chris at chris-wilson.co.uk
Tue Nov 26 12:52:58 UTC 2019


Quoting Dan Carpenter (2019-11-26 12:50:03)
> We should be unmapping "page" instead of "s".  This code originally used
> kmap_atomic() before it was changed to kmap().  The two mapping
> functions are different which leads to this common mistake.
> 
> Fixes: 3e749f5199e1 ("drm/i915: Avoid atomic context for error capture")
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

Caught by bae21dacd7b7 ("drm/i915: Switch kunmap() to take the page not
vaddr")

Thanks for smatch!
-Chris


More information about the Intel-gfx mailing list