[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Support more QGV points (rev4)

Ville Syrjälä ville.syrjala at linux.intel.com
Tue Nov 26 16:31:05 UTC 2019


On Mon, Nov 25, 2019 at 05:01:53PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Support more QGV points (rev4)
> URL   : https://patchwork.freedesktop.org/series/69886/
> State : warning
> 
> == Summary ==
> 
> $ dim checkpatch origin/drm-tip
> d993a329d475 drm/i915: Support more QGV points
> -:45: CHECK:BRACES: braces {} should be used on all arms of this statement
> #45: FILE: drivers/gpu/drm/i915/display/intel_bw.c:279:
> +	if (INTEL_GEN(dev_priv) >= 11) {
> [...]
> +		}
> [...]

Still has a trivial checkpatch issue. I fixed this while pushing.
Next time please try to fix these before sending the patch.

Also "Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=112189"
is wrong. It should be "Bugzilla: <link>". dim refused to push due to
this so had to fix this one as well.

Anyways, now pushed to dinq. Thanks for the patch.

-- 
Ville Syrjälä
Intel


More information about the Intel-gfx mailing list