[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

Patchwork patchwork at emeril.freedesktop.org
Thu Nov 28 15:50:48 UTC 2019


== Series Details ==

Series: drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET
URL   : https://patchwork.freedesktop.org/series/70164/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
11ae1f7889b6 drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET
-:416: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#416: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:588:
+i915_gem_mmap_dumb(struct drm_file *file,
+		  struct drm_device *dev,

-:426: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#426: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:598:
+		return -ENODEV;
+	else

-:588: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#588: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:763:
+
+	}

-:629: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#629: 
new file mode 100644

-:634: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#634: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.h:1:
+/*

-:635: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#635: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.h:2:
+ * SPDX-License-Identifier: MIT

-:661: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#661: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.h:28:
+int i915_gem_mmap_dumb(struct drm_file *file_priv, struct drm_device *dev,
+		      u32 handle, u64 *offset);

-:860: CHECK:LINE_SPACING: Please don't use multiple blank lines
#860: FILE: drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c:581:
 
+

-:1150: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#1150: FILE: drivers/gpu/drm/i915/i915_getparam.c:2:
  * SPDX-License-Identifier: MIT

-:1200: WARNING:LONG_LINE: line over 100 characters
#1200: FILE: include/uapi/drm/i915_drm.h:398:
+#define DRM_IOCTL_I915_GEM_MMAP_OFFSET	DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_MMAP_GTT, struct drm_i915_gem_mmap_offset)

total: 0 errors, 6 warnings, 4 checks, 1075 lines checked



More information about the Intel-gfx mailing list