[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: i915_display_info cleanup

Patchwork patchwork at emeril.freedesktop.org
Fri Nov 29 21:43:27 UTC 2019


== Series Details ==

Series: drm/i915: i915_display_info cleanup
URL   : https://patchwork.freedesktop.org/series/70222/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
6356e0862ab6 drm/i915: Use drm_rect to simplify plane {crtc, src}_{x, y, w, h} printing
-:41: WARNING:LONG_LINE: line over 100 characters
#41: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2624:
+		seq_printf(m, "\t--Plane id %d: type=%s, dst=" DRM_RECT_FMT ", src=" DRM_RECT_FP_FMT ", format=%s, rotation=%s\n",

total: 0 errors, 1 warnings, 0 checks, 38 lines checked
2a80e4622b63 drm/i915: Switch to intel_ types in debugfs display_info
b62404023212 drm/i915: Reorganize plane/fb dump in debugfs
-:62: WARNING:LONG_LINE: line over 100 characters
#62: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2601:
+		seq_printf(m, "\t--Plane id %d: type=%s, fb=%d,%s,%dx%d, src=" DRM_RECT_FP_FMT ", dst=" DRM_RECT_FMT ", rotation=%s\n",

total: 0 errors, 1 warnings, 0 checks, 80 lines checked
b0243cfbf813 drm/i915: Refactor debugfs display info code
7daef64f127f drm/i915: Dump the mode for the crtc just the once
cb15b4882e11 drm/i915: Use drm_modeset_lock_all() in debugfs display info
1932dba700b8 drm/i915: Use the canonical [CRTC:%d:%s]/etc. format in i915_display_info
-:50: WARNING:LONG_LINE: line over 100 characters
#50: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2588:
+		seq_printf(m, "\t[PLANE:%d:%s]: type=%s, fb=%d,%s,%dx%d, src=" DRM_RECT_FP_FMT ", dst=" DRM_RECT_FMT ", rotation=%s\n",

total: 0 errors, 1 warnings, 0 checks, 41 lines checked
c8b8d3658b34 drm/i915: Dump both the uapi and hw states for crtcs and planes
-:87: WARNING:LONG_LINE: line over 100 characters
#87: FILE: drivers/gpu/drm/i915/i915_debugfs.c:2601:
+	seq_printf(m, "\t\thw: fb=%d,%s,%dx%d, visible=%s, src=" DRM_RECT_FP_FMT ", dst=" DRM_RECT_FMT ", rotation=%s\n",

total: 0 errors, 1 warnings, 0 checks, 142 lines checked
108411fb7af8 drm/i915: Stop using connector->encoder and encoder->crtc links in i915_display_info
-:24: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#24: FILE: drivers/gpu/drm/i915/display/intel_display.h:383:
+#define for_each_intel_encoder_mask(dev, intel_encoder, encoder_mask)	\
+	list_for_each_entry(intel_encoder,				\
+			    &(dev)->mode_config.encoder_list,		\
+			    base.head)					\
+		for_each_if((encoder_mask) &				\
+			    drm_encoder_mask(&intel_encoder->base))

-:24: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_encoder' - possible side-effects?
#24: FILE: drivers/gpu/drm/i915/display/intel_display.h:383:
+#define for_each_intel_encoder_mask(dev, intel_encoder, encoder_mask)	\
+	list_for_each_entry(intel_encoder,				\
+			    &(dev)->mode_config.encoder_list,		\
+			    base.head)					\
+		for_each_if((encoder_mask) &				\
+			    drm_encoder_mask(&intel_encoder->base))

total: 1 errors, 0 warnings, 1 checks, 113 lines checked



More information about the Intel-gfx mailing list