[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Conclude load -> probe naming convention switch

[Janusz Krzysztofik]

On Tuesday, October 1, 2019 9:08:48 PM CEST Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Conclude load -> probe naming convention switch
> URL   : https://patchwork.freedesktop.org/series/67454/
> State : warning
> 
> == Summary ==
> 
> $ dim checkpatch origin/drm-tip
> f23ba0cec202 drm/i915: Fix i915_inject_load_error() name to read *_probe_*
> -:11: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" consequently")'
> #11: 
> established by commit f2db53f14d3d ("drm/i915: Replace "_load" with

False positive, unless it is illegal to use double quotes in commit titles, 
otherwise current convention of quoting commit titles with ("...") may result 
in nested double quotes, not handled correctly by checkpatch.

> total: 1 errors, 0 warnings, 0 checks, 158 lines checked
> 99ddd1e63a9f drm/i915: Rename "inject_load_failure" module parameter
> -:9: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'Commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe" consequently")'
> #9: 
> Commit f2db53f14d3d ("drm/i915: Replace "_load" with "_probe"

ditto

> -:34: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
> #34: FILE: drivers/gpu/drm/i915/i915_params.c:169:
> +i915_param_named_unsafe(inject_probe_failure, uint, 0400,
>  	"Force an error after a number of failure check points (0:disabled (default), N:force failure at the Nth failure check point)");

Quoting Chris [1]: 
"This is one where we've considered the merits of not rigorously applying
checkpatch.pl and adopted a different convention."

Thanks,
Janusz

[1] https://lists.freedesktop.org/archives/intel-gfx/2019-July/205030.html

> 
> total: 1 errors, 0 warnings, 1 checks, 43 lines checked
> 
>