[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore

Patchwork patchwork at emeril.freedesktop.org
Wed Oct 2 13:21:25 UTC 2019


== Series Details ==

Series: series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore
URL   : https://patchwork.freedesktop.org/series/67483/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
099f6ae3c72d drm/i915/selftests: Exercise potential false lite-restore
48a5a08e3523 dma-fence: Serialise signal enabling (dma_fence_enable_sw_signaling)
-:14: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0fc89b6802ba ("dma-fence: Simply wrap dma_fence_signal_locked with dma_fence_signal")'
#14: 
See also 0fc89b6802ba ("dma-fence: Simply wrap dma_fence_signal_locked

total: 1 errors, 0 warnings, 0 checks, 24 lines checked
e93a397fa0d2 drm/mm: Pack allocated/scanned boolean into a bitfield
6642ae7aa59e drm/i915: Only track bound elements of the GTT
24c5d7101d43 drm/i915: Mark up address spaces that may need to allocate
4780268eb9ee drm/i915: Pull i915_vma_pin under the vm->mutex
ac368d894b03 drm/i915: Push the i915_active.retire into a worker
599d9ac80be6 drm/i915: Coordinate i915_active with its own mutex
-:1339: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#1339: FILE: drivers/gpu/drm/i915/i915_active_types.h:49:
+	struct mutex mutex;

total: 0 errors, 0 warnings, 1 checks, 1481 lines checked
609a95b5ebdd drm/i915: Move idle barrier cleanup into engine-pm
3e257cd827c5 drm/i915: Drop struct_mutex from around i915_retire_requests()
b34f4178512d drm/i915: Remove the GEM idle worker
549ca7d3ccb8 drm/i915: Merge wait_for_timelines with retire_request
5f78b2d8eaa1 drm/i915/gem: Retire directly for mmap-offset shrinking
0f64ec7c4dc9 drm/i915: Move request runtime management onto gt
-:235: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#235: 
new file mode 100644

-:240: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#240: FILE: drivers/gpu/drm/i915/gt/intel_gt_requests.c:1:
+/*

-:241: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#241: FILE: drivers/gpu/drm/i915/gt/intel_gt_requests.c:2:
+ * SPDX-License-Identifier: MIT

-:369: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#369: FILE: drivers/gpu/drm/i915/gt/intel_gt_requests.h:1:
+/*

-:370: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#370: FILE: drivers/gpu/drm/i915/gt/intel_gt_requests.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 725 lines checked
d806a7455a70 drm/i915: Move global activity tracking from GEM to GT
ed2665cd47ce drm/i915: Expose engine properties via sysfs
-:68: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#68: 
new file mode 100644

-:73: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#73: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.c:1:
+/*

-:74: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#74: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.c:2:
+ * SPDX-License-Identifier: MIT

-:198: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#198: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.h:1:
+/*

-:199: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#199: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 158 lines checked
a1ec3bd4b994 drm/i915/execlists: Force preemption
7392453b5491 drm/i915: Mark up "sentinel" requests
a84e25080394 drm/i915/execlists: Cancel banned contexts on schedule-out
36c0ae8588b3 drm/i915: Cancel non-persistent contexts on close
-:282: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#282: 
new file mode 100644

-:287: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#287: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:1:
+/*

-:288: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#288: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:2:
+ * SPDX-License-Identifier: MIT

-:349: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#349: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.h:1:
+/*

-:350: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#350: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 319 lines checked
01065375a0b4 drm/i915: Replace hangcheck by heartbeats
-:236: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'heartbeat', this function's name, in a string
#236: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:69:
+					  "%s heartbeat not ticking\n",

-:253: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'heartbeat', this function's name, in a string
#253: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:86:
+					      "stopped heartbeat on %s",

-:540: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#540: 
deleted file mode 100644

total: 0 errors, 3 warnings, 0 checks, 672 lines checked
1c94e090a34e drm/i915: Remove logical HW ID
1e6d926f34c5 drm/i915: Move context management under GEM
-:1061: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1061: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:988:
+#define GEN11_MAX_CONTEXT_HW_ID (1<<11) /* exclusive */
                                   ^

total: 0 errors, 0 warnings, 1 checks, 1717 lines checked
e9936b3ae50f drm/i915/overlay: Drop struct_mutex guard
8fc7dc0d282a drm/i915: Drop struct_mutex guard from debugfs/framebuffer_info
e472c60fd9d7 drm/i915: Remove struct_mutex guard for debugfs/opregion
e5dc8b772718 drm/i915: Drop struct_mutex from suspend state save/restore
132ce69b74db drm/i915/selftests: Drop vestigal struct_mutex guards
277ca2deb924 drm/i915: Drop struct_mutex from around GEM initialisation
b88fbb322e7a drm/i915: Flush idle barriers when waiting



More information about the Intel-gfx mailing list