[Intel-gfx] [PATCH 21/30] drm/i915: Replace hangcheck by heartbeats

[Chris Wilson]

Quoting Bloomfield, Jon (2019-10-02 14:55:32)
> > -----Original Message-----
> > From: Chris Wilson <chris at chris-wilson.co.uk>
> > Sent: Wednesday, October 2, 2019 4:20 AM
> > To: intel-gfx at lists.freedesktop.org
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>; Joonas Lahtinen
> > <joonas.lahtinen at linux.intel.com>; Ursulin, Tvrtko <tvrtko.ursulin at intel.com>;
> > Bloomfield, Jon <jon.bloomfield at intel.com>
> > Subject: [PATCH 21/30] drm/i915: Replace hangcheck by heartbeats
> > 
> > Replace sampling the engine state every so often with a periodic
> > heartbeat request to measure the health of an engine. This is coupled
> > with the forced-preemption to allow long running requests to survive so
> > long as they do not block other users.
> > 
> > The heartbeat interval can be adjusted per-engine using,
> > 
> >       /sys/class/drm/card0/engine/*/heartbeat_interval_ms
> 
> Not true for discrete :-)
> 
> Perhaps: /sys/class/drm/card<n>/engine/*/heartbeat_interval_ms
> And again in the code below.

I left the extrapolation to the user -- I thought it was clear enough
without saying cardN, card<N>, or card?. Though since it's using
globing in one location card?
-Chris