[Intel-gfx] [PATCH v2 01/22] drm/i915/stolen: make the object creation interface consistent

[Chris Wilson]

Quoting Matthew Auld (2019-10-03 20:24:23)
> diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
> index d6167dd592e9..dcf189f26624 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rc6.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
> @@ -299,7 +299,7 @@ static int vlv_rc6_init(struct intel_rc6 *rc6)
>                                                                       pcbr_offset,
>                                                                       I915_GTT_OFFSET_NONE,
>                                                                       pctx_size);
> -               if (!pctx)
> +               if (IS_ERR(pctx))
>                         return -ENOMEM;
>  
>                 goto out;
> @@ -316,7 +316,7 @@ static int vlv_rc6_init(struct intel_rc6 *rc6)
>          * memory, or any other relevant ranges.
>          */
>         pctx = i915_gem_object_create_stolen(i915, pctx_size);
> -       if (!pctx) {
> +       if (IS_ERR(pctx)) {
>                 DRM_DEBUG("not enough stolen space for PCTX, disabling\n");
>                 return -ENOMEM;

You might as well make use of the actual error now that you know it.

With that minor tweak,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris