[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for LMEM basics (rev3)

Patchwork patchwork at emeril.freedesktop.org
Fri Oct 4 18:09:56 UTC 2019


== Series Details ==

Series: LMEM basics (rev3)
URL   : https://patchwork.freedesktop.org/series/67350/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
230ce2751c83 drm/i915/stolen: make the object creation interface consistent
-:89: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!obj"
#89: FILE: drivers/gpu/drm/i915/gem/i915_gem_stolen.c:602:
+	if (obj == NULL) {

total: 0 errors, 0 warnings, 1 checks, 150 lines checked
49d114bc9547 drm/i915: introduce intel_memory_region
-:59: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100644

-:600: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#600: FILE: drivers/gpu/drm/i915/intel_memory_region.h:44:
+	struct mutex mm_lock;

total: 0 errors, 1 warnings, 1 checks, 775 lines checked
c846cb7cad7d drm/i915/region: support contiguous allocations
-:317: WARNING:LINE_SPACING: Missing a blank line after declarations
#317: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:130:
+	LIST_HEAD(holes);
+	I915_RND_STATE(prng);

total: 0 errors, 1 warnings, 0 checks, 393 lines checked
0339d6513672 drm/i915/region: support volatile objects
6c7235302062 drm/i915: Add memory region information to device_info
97b8c777c4d0 drm/i915: support creating LMEM objects
-:35: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#35: 
new file mode 100644

-:137: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#137: FILE: drivers/gpu/drm/i915/intel_memory_region.c:10:
+#define REGION_MAP(type, inst) \
+	BIT((type) + INTEL_MEMORY_TYPE_SHIFT) | BIT(inst)

total: 1 errors, 1 warnings, 0 checks, 262 lines checked
94b66fcc5efd drm/i915: setup io-mapping for LMEM
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 34 lines checked
aa7fd71d6788 drm/i915/lmem: support kernel mapping
-:200: WARNING:LINE_SPACING: Missing a blank line after declarations
#200: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:282:
+	struct drm_i915_gem_object *obj;
+	I915_RND_STATE(prng);

total: 0 errors, 1 warnings, 0 checks, 273 lines checked
5e5781be3c3c drm/i915/selftests: add write-dword test for LMEM
-:19: CHECK:LINE_SPACING: Please don't use multiple blank lines
#19: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:10:
 
+

-:88: WARNING:LINE_SPACING: Missing a blank line after declarations
#88: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:312:
+	struct intel_context *ce;
+	I915_RND_STATE(prng);

-:168: WARNING:LINE_SPACING: Missing a blank line after declarations
#168: FILE: drivers/gpu/drm/i915/selftests/intel_memory_region.c:406:
+	struct drm_file *file;
+	I915_RND_STATE(prng);

total: 0 errors, 2 warnings, 1 checks, 198 lines checked
0dfe20962fb0 drm/i915/selftests: extend coverage to include LMEM huge-pages
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 151 lines checked
2797cf97e640 drm/i915: enumerate and init each supported region
164771ef0b1f drm/i915: treat shmem as a region
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 352 lines checked
fe16f6f25391 drm/i915: treat stolen as a region
a4c11ba258ec drm/i915: define i915_ggtt_has_aperture
955419c5d802 drm/i915: do not map aperture if it is not available.
-:38: CHECK:SPACING: No space is necessary after a cast
#38: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:3042:
+			(struct resource) DEFINE_RES_MEM(pci_resource_start(pdev, 2),

total: 0 errors, 0 warnings, 1 checks, 51 lines checked
69132ab6cb6e drm/i915: set num_fence_regs to 0 if there is no aperture
dacd250f584e drm/i915: error capture with no ggtt slot
bd4af504601f drm/i915: Don't try to place HWS in non-existing mappable region
eca4aec7ec7e drm/i915: don't allocate the ring in stolen if we lack aperture
625162b64039 drm/i915/selftests: check for missing aperture
9db91fb25dff HAX drm/i915: add the fake lmem region
-:49: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
#49: FILE: arch/x86/kernel/early-quirks.c:624:
+	printk(KERN_INFO "Intel graphics fake LMEM starts at %pa\n",

total: 0 errors, 1 warnings, 0 checks, 228 lines checked



More information about the Intel-gfx mailing list